IsoScene.removeChildByID not testing for null result

[GoogleCodeExporter]

I'm concerned that calling myScene.removeChildByID(id)   will still 
invalidate a scene even if the child does not exist, which would be non-
ideal.

Here's the code in question, from IsoScene.as:

override public function removeChildByID (id:String):INode
       {
           var child:INode = super.removeChildByID(id);
           child.removeEventListener(IsoEvent.INVALIDATE, 
child_invalidateHandler);
                     _isInvalidated = true;
                     return child;
       }

I haven't tested but expect the above code to fail when the call 
removeEventListener is performed on a null object.

Original issue reported on code.google.com by hello.ja...@gmail.com on 22 Apr 2009 at 4:54

[GoogleCodeExporter]

Here's a possible patch:

override public function removeChildByID (id:String):INode
{
    var child:INode = super.removeChildByID(id);

    if ( child ) {
        child.removeEventListener(IsoEvent.INVALIDATE, child_invalidateHandler);
        _isInvalidated = true;
    }

    return child;
}

Original comment by hello.ja...@gmail.com on 22 Apr 2009 at 4:57

[GoogleCodeExporter]

Original comment by jwopitz on 22 Apr 2009 at 10:36

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by jwopitz on 4 May 2009 at 8:05

• Changed state: Fixed