alexwenzel / nova-dependency-container

A Laravel Nova field container allowing to depend on other fields values
MIT License
46 stars 33 forks source link

Duplicate field.js assets #13

Closed szymon-szychulski closed 1 year ago

szymon-szychulski commented 1 year ago

In the source code of the page I noticed a duplicate javascript code for the field:

<!-- Tool Scripts -->
<script src="/vendor/nova-kit/nova-packages-tool/tool.js"></script>
<script src="/nova-api/scripts/dependency-container"></script>
<script src="/nova-api/scripts/nova-dependency-container"></script>

Both files are the same, and the FieldServiceProvider has double their definitions, with a different name:

public function boot(): void
{
    // assets
    Nova::serving(function (ServingNova $event) {
        Nova::script('dependency-container', __DIR__.'/../dist/js/field.js');
        Nova::style('dependency-container', __DIR__.'/../dist/css/field.css');
    });

    ...

    Nova::serving(function (ServingNova $event) {
        Nova::script('nova-dependency-container', __DIR__.'/../dist/js/field.js');
    });
}

Is it on purpose or a mistake?