search

alexwhitman / node-pushbullet-api

PushBullet API module for Node.js
165 stars 36 forks source link

Allow a message when pushing a link #18

Closed brantje closed 8 years ago

menzerath commented 9 years ago

Would love to have this simple, but important addition in the module. :+1:

alexwhitman commented 9 years ago

@brantje Thanks for the pull request. If you can make it backwards compatible so that the function can still be called without a message I'll get it merged. Something like

if ( ! callback) {
    url = body;
    callback = url;
    body = null;
}

Also the readme will need updating.

brantje commented 9 years ago

@MarvinMenzerath Are you ok with this?

menzerath commented 9 years ago

@brantje This isn't my repository, but I like the changes. You should rather ask @alexwhitman. :smile:

alexwhitman commented 8 years ago

Fixed by 2064147d1d462e7ff38c99f487c5485abdfb75e0