search

alexxed / narro

Automatically exported from code.google.com/p/narro
2 stars 4 forks source link

Lost some approved translations #184

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
In the attached patch you can see that I am loosing approved translations after 
the upgrade we had few weeks ago.

To recover from this I do the following:
hg revert security/manager/chrome/pipnss/pipnss.properties
hg revert security/manager/chrome/pippki/certManager.dtd
hg revert security/manager/chrome/pippki/deviceManager.dtd
hg revert security/manager/chrome/pippki/pippki.dtd
hg revert security/manager/chrome/pippki/validation.dtd

I might go on Narro and revalidate 4 out of the 5 files so I don't have to have 
this hacky steps but leave one of the files in case you want to debug this 
issue. I can't promise that the other approvers won't approve it in their own.

To reproduce the problem you can use the attached zip (it was exported today) 
and these instructions:
hg clone http://hg.mozilla.org/releases/l10n/mozilla-aurora/hy-AM
cd hy-AM
hg up -r f8a1dc0ff6b6
unzip ~/Downloads/Firefox\ Aurora-hy-AM.zip (accept to overwrite all)
# NOTICE that the following steps are my normal set of steps:
# Re-add license headers
modules=( browser dom netwerk security toolkit); \
for module in ${modules[@]}; do cd $module; \
for file in \
`find .  -name "*dtd" -type f`; do \
cat /Users/armenzg/repos/armenian/header.dtd $file > $file.new; mv $file.new 
$file; done; \
for file in \
`find . -name "*properties" ! -name region.properties -type f`; do \
cat /Users/armenzg/repos/armenian/header.properties $file > $file.new; mv 
$file.new $file; done; cd ..; done;

# Remove last 2 empty lines
for file in `find . -name "*dtd" ! -name report-phishing.dtd`; do sed 
'N;$!P;$!D;$d' $file > $file.new && \
mv $file.new $file ; done
for file in `find . -name "*properties" ! -name finddialog.properties ! -name 
region.properties`; \
do sed 'N;$!P;$!D;$d' $file > $file.new && \
mv $file.new $file ; done
for file in `find . -name "*ini"`; do sed 'N;$!P;$!D;$d' $file > $file.new && \
mv $file.new $file ; done

# Weird files
hg remove browser/README.txt
hg revert browser/chrome/browser-region/region.properties
hg revert toolkit/chrome/global-region/region.properties

Original issue reported on code.google.com by arme...@gmail.com on 19 Sep 2011 at 7:09

Attachments:

GoogleCodeExporter commented 9 years ago 
Did you try to import the good files in Narro so that they are marked as 
approved ?
Or is this an issue with translations kept as original ?

Original comment by alex...@gmail.com on 21 Sep 2011 at 5:23

GoogleCodeExporter commented 9 years ago 
Also note that I have the backend to store file headers per language in the 
export file, so if you didn't open an issue for that, you should do it know so 
I can add it somewhere in the interface.

Original comment by alex...@gmail.com on 21 Sep 2011 at 5:24

GoogleCodeExporter commented 9 years ago 
WRT to comment 1.
- This started happening few weeks back at the last upgrade of Narro. Importing 
the files from my hg checkout maintained the status quo.
I have been now been able to export and commit properly.

Find attached the headers. Thanks a lot.

Do you have an issue for tracking the extra 2 empty lines that each file gets?

Original comment by arme...@gmail.com on 22 Sep 2011 at 4:11

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by alex...@gmail.com on 13 Oct 2011 at 6:05