search

alexxed / narro

Automatically exported from code.google.com/p/narro
2 stars 4 forks source link

Narro nukes the access keys on export #316

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Check out the latest exported Serbian L10n at 
http://a.maimult.ro/lmo/includes/narro/plugins/NarroExportArchive.class.php?p=34
&pn=Firefox%20Beta&l=sr
2. See the attached files -- the diff from the previous version in 
after-export.part, and the list of access keys nuked at 
access-keys-removed.patch.part
3.

What is the expected output? What do you see instead?
Narro shouldn't ever nuke access keys if the translations thereof are present.

What version of the product are you using?
Whatever is now current on the narro website.

Original issue reported on code.google.com by fil...@gmail.com on 1 Jul 2012 at 10:27

Attachments:

GoogleCodeExporter commented 9 years ago 
What do you mean by nuke ? Is there nothing exported or is the English access 
key exported ?

Original comment by alex...@gmail.com on 10 Jul 2012 at 5:39

GoogleCodeExporter commented 9 years ago 
Any news on this ? I need a specific example of one file and one access key 
refered by its key in the file to be able to research this.

Original comment by alex...@gmail.com on 19 Jul 2012 at 5:23

GoogleCodeExporter commented 9 years ago 
Sorry, I've been busy elsewhere.  Will make an example once able.

Original comment by fil...@gmail.com on 19 Jul 2012 at 5:53

GoogleCodeExporter commented 9 years ago 
http://mxr.mozilla.org/l10n-mozilla-aurora/source/ms/dom/chrome/layout/htmlparse
r.properties#50 is likely one of the examples of busted '&' handling.

As are the '&' in dom/chrome/layout/htmlparser.properties 
browser/chrome/browser/quitDialog.properties 
browser/chrome/browser-region/region.properties 
browser/installer/custom.properties browser/installer/mui.properties 
browser/installer/override.properties 
toolkit/chrome/global/commonDialogs.properties 
toolkit/chrome/passwordmgr/passwordmgr.properties 
toolkit/chrome/search/search.properties

This leads to horribly broken localizations. Beyond broken accesskeys, this 
breaks installer variables, I've come across various places that talk about 
$Brand&ShortName.

Original comment by l10n....@gmail.com on 20 Jul 2012 at 4:11

GoogleCodeExporter commented 9 years ago 
There where three problems in total, all fixed in other issues. Can you please 
retest?

Original comment by alex...@gmail.com on 24 Jul 2012 at 7:50