search

alexyork / TrondheimDC-WebApp

TrondheimDC-WebApp
3 stars 1 forks source link

Show favourites grouped by timeslot #32

Closed alexyork closed 12 years ago

alexyork commented 12 years ago

The sessions list is grouped by timeslot. Maybe the favourites list should be too.

alexyork commented 12 years ago

Leave this to me for now, I need to refactor some timeslot stuff before anyone can work on this.

alexyork commented 12 years ago

Andre, you can do this if you have the time.

yornaath commented 12 years ago

Il most likely get it done tomorow

alexyork commented 12 years ago

OK, no problem. For now, this is the only task that I perceive to be "top priority". Other than this one, we are good to go, or the others are just "nice to haves" :-)

hegerokenes commented 12 years ago

+1 on that Alex

yornaath commented 12 years ago

Ok I have implemented this. One question though. Should the view be identical to the sessions list view just containing favourited sessions? Or should we hide timeslots with no favourites?

alexyork commented 12 years ago

What you have done is perfect. No more changes needed.

I made a slight change though. I used a separate template for the favourites. I did this because I did not want the search functionality to be on the favourites view.

The way you had done it, we had the search bar on the favourites view, and using it showed search results for sessions that were not favourites, even though we were on the favouites page. See my latest commit.

I am closing this issue now. Great work folks!

hegerokenes commented 12 years ago

If we are going to show timeslots, do we want to show the once with breakes and stuff? And in empty timeslots we whould have to show a text saying "no favorites in this timeslot". It can be useful to see that you have an empty timeslot at a certain given time. But it does sound more complicating than just hiding the empty once. The user will see that he/she has a large time gap.