search

alexyoung / ircd.js

A Node ircd (IRC daemon)
GNU General Public License v3.0
528 stars 90 forks source link

Crash #19

Closed treeform closed 12 years ago

treeform commented 12 years ago

[server1, C: Kettch23] USER Kettch Kettch irc.aff2aw.com :Kettch S: [Kettch23] :localhost 001 Kettch23 Welcome to the ircn IRC network :Kettch23!Kettch@188.111.108.254 S: [Kettch23] :localhost 002 Kettch23 Your host is localhost running version 0.0.4 S: [Kettch23] :localhost 003 Kettch23 This server was created on 2011-10-31 S: [Kettch23] :localhost 004 Kettch23 0.0.4 S: [Kettch23] :localhost 375 Kettch23 :- Message of the Day - S: [Kettch23] :localhost 372 Kettch23 :- S: [Kettch23] :localhost 376 Kettch23 :End of /MOTD command. S: [Kettch23] :Kettch23!Kettch@188.111.108.254 MODE Kettch23 +w Kettch23 [server1, C: Kettch23] JOIN #aff,#psbeta,#public ,secret

/p/ircd.js/lib/user.js:98 var parts = mask.match(/([^!])!([^@])@(.*)/) || [], ^ TypeError: Cannot call method 'match' of undefined at Object.matchesMask (/p/ircd.js/lib/user.js:98:22) at /p/ircd.js/lib/channel.js:83:19 at Array.some (native) at Object.isBanned (/p/ircd.js/lib/channel.js:82:24) at Object.join (/p/ircd.js/lib/storage.js:122:17) at /p/ircd.js/lib/commands.js:72:25 at Array.forEach (native) at Object. (/p/ircd.js/lib/commands.js:64:29) at EventEmitter. (/p/ircd.js/lib/server.js:112:34) at EventEmitter.emit (events.js:72:17)

alexyoung commented 12 years ago

It looks like that "JOIN #aff,#psbeta,#public ,secret" did it somehow

treeform commented 12 years ago

Another one:

[server1, C: ikarus] PRIVMSG #aff :nice ! S: [SkyWay] :ikarus!ikarus@adsl92-82-225-135.romtelecom.net PRIVMSG #aff :nice ! S: [Stranj____] :ikarus!ikarus@adsl92-82-225-135.romtelecom.net PRIVMSG #aff :nice ! S: [Sudazima] :ikarus!ikarus@adsl92-82-225-135.romtelecom.net PRIVMSG #aff :nice ! S: [farseer] :ikarus!ikarus@adsl92-82-225-135.romtelecom.net PRIVMSG #aff :nice ! S: [XyxAFK] :ikarus!ikarus@adsl92-82-225-135.romtelecom.net PRIVMSG #aff :nice ! S: [Kettch23] :ikarus!ikarus@adsl92-82-225-135.romtelecom.net PRIVMSG #aff :nice ! S: [treeform] :ikarus!ikarus@adsl92-82-225-135.romtelecom.net PRIVMSG #aff :nice ! S: [Jetfire3] :ikarus!ikarus@adsl92-82-225-135.romtelecom.net PRIVMSG #aff :nice ! S: [Serg2] :ikarus!ikarus@adsl92-82-225-135.romtelecom.net PRIVMSG #aff :nice ! [server1, C: null] NICK Sudazima S: [null] :null!null@217.149.206.138 NICK :Sudazima [server1, C: Sudazima] USER sudazima 0 * :sudazima S: [Sudazima] :localhost 001 Sudazima Welcome to the ircn IRC network :Sudazima!sudazima@217.149.206.138 S: [Sudazima] :localhost 002 Sudazima Your host is localhost running version 0.0.4 S: [Sudazima] :localhost 003 Sudazima This server was created on 2011-10-31 S: [Sudazima] :localhost 004 Sudazima 0.0.4 S: [Sudazima] :localhost 375 Sudazima :- Message of the Day - S: [Sudazima] :localhost 372 Sudazima :- S: [Sudazima] :localhost 376 Sudazima :End of /MOTD command. S: [Sudazima] :Sudazima!sudazima@217.149.206.138 MODE Sudazima +w Sudazima [server1, C: Sudazima] USERHOST :Sudazima [server1, C: Sudazima] hidewindow [server1, C: Sudazima] JOIN #aff

/p/ircd.js/lib/user.js:98 var parts = mask.match(/([^!])!([^@])@(.*)/) || [], ^ TypeError: Cannot call method 'match' of undefined at Object.matchesMask (/p/ircd.js/lib/user.js:98:22) at /p/ircd.js/lib/channel.js:83:19 at Array.some (native) at Object.isBanned (/p/ircd.js/lib/channel.js:82:24) at Object.join (/p/ircd.js/lib/storage.js:122:17) at /p/ircd.js/lib/commands.js:72:25 at Array.forEach (native) at Object. (/p/ircd.js/lib/commands.js:64:29) at EventEmitter. (/p/ircd.js/lib/server.js:112:34) at EventEmitter.emit (events.js:72:17)

alexyoung commented 12 years ago

What did you do?

treeform commented 12 years ago

S: [null] :localhost 433 * XyxAFK :is already in use [server1, C: null] USER Xyx unknown unknown :Xyx [server1, C: null] NICK XyxAFK S: [null] :null!Xyx@42-1-223.ftth.xms.internl.net NICK :XyxAFK S: [XyxAFK] :localhost 001 XyxAFK Welcome to the ircn IRC network :XyxAFK!Xyx@42-1-223.ftth.xms.internl.net S: [XyxAFK] :localhost 002 XyxAFK Your host is localhost running version 0.0.4 S: [XyxAFK] :localhost 003 XyxAFK This server was created on 2011-10-31 S: [XyxAFK] :localhost 004 XyxAFK 0.0.4 S: [XyxAFK] :localhost 375 XyxAFK :- Message of the Day - S: [XyxAFK] :localhost 372 XyxAFK :- S: [XyxAFK] :localhost 376 XyxAFK :End of /MOTD command. S: [XyxAFK] :XyxAFK!Xyx@42-1-223.ftth.xms.internl.net MODE XyxAFK +w XyxAFK [server1, C: XyxAFK] JOIN #aff

/p/ircd.js/lib/user.js:98 var parts = mask.match(/([^!])!([^@])@(.*)/) || [], ^ TypeError: Cannot call method 'match' of undefined at Object.matchesMask (/p/ircd.js/lib/user.js:98:22) at /p/ircd.js/lib/channel.js:83:19 at Array.some (native) at Object.isBanned (/p/ircd.js/lib/channel.js:82:24) at Object.join (/p/ircd.js/lib/storage.js:122:17) at /p/ircd.js/lib/commands.js:72:25 at Array.forEach (native) at Object. (/p/ircd.js/lib/commands.js:64:29) at EventEmitter. (/p/ircd.js/lib/server.js:112:34) at EventEmitter.emit (events.js:72:17)

alexyoung commented 12 years ago

It seems like we just need a guard around that mask.match code, but I'll have to try to reproduce what you're seeing first.

alexyoung commented 12 years ago

Why are you running '0.0.4' and not the updated version (0.0.5)?

alexyoung commented 12 years ago

This was caused by invalid ban masks on a channel. If you still find crashes like this, just raise another bug with the transcript and I'll take a look.

Install 0.0.6 from npm or get the latest commits to fix this.

treeform commented 12 years ago

Thanks!