search

alexyoung / ircd.js

A Node ircd (IRC daemon)
GNU General Public License v3.0
528 stars 90 forks source link

Add callbacks to server.start and close, another test case, fix coding style issues #7

Closed niklasf closed 13 years ago

niklasf commented 13 years ago

Hi, another pull request. You might want to cherry pick some or apply all. Grouping them a little:

Coding style

708edaa2 Fixes a typo in my regular expression 961a1e54 Adjust indendation of my testcase to two spaces which you use in your other files

Callbacks

Optional callbacks for server.start and close. I found this useful when I required a server. ee593f5c for server.start() 096ff460 for server.close()

Testcase

194d0fe4 You only want to cherry-pick it if nodeunit (npm install nodeunit) is ok. The test passes here.

-- Kind regards, Niklas

alexyoung commented 13 years ago

I realise most JavaScript projects are 4 spaces, I actually use 2 spaces a lot because it's easier to read in my blog posts (I don't really have a preference though).

I like the idea of the callbacks. I'll take a look at this locally then merge.

alexyoung commented 13 years ago

I've merged this in