alexyoung / ircd.js

A Node ircd (IRC daemon)
GNU General Public License v3.0
528 stars 90 forks source link

Fix: Don't crash on kick without user #84

Open TheBenji opened 9 years ago

TheBenji commented 9 years ago

If you do "/KICK " and don't specify a user the server crashes

home/ben/workspace/ircd.js/lib/commands.js:123 userNames = users.split(','), ^ TypeError: Cannot call method 'split' of undefined at Object.Commands.KICK (/home/ben/workspace/ircd.js/lib/commands.js:123:27) at Object.Server.respondToMessage (/home/ben/workspace/ircd.js/lib/server.js:171:36) at Object.Server.respond (/home/ben/workspace/ircd.js/lib/server.js:181:14) at Object.Server.data (/home/ben/workspace/ircd.js/lib/server.js:320:10) at Carrier. (/home/ben/workspace/ircd.js/lib/server.js:277:51) at Carrier.emit (events.js:95:17) at /home/ben/workspace/ircd.js/node_modules/carrier/lib/carrier.js:71:15 at process._tickCallback (node.js:419:13)

Doesn't happen anymore with this fix and just sends an "needs more arguments"

sespindola commented 9 years ago

Good catch, thanks for the fix. Your patch seems to alter the indentation of several lines. Could you please clean that up?

TheBenji commented 9 years ago

Just seems like it. The whole part between l137-160 is now within the "else"-block and therefore the indentation moved a little.

I (well, my editor :P) also removed the trailing whitespaces (l336 & l498).

Hope that makes sense

orliesaurus commented 9 years ago

Can you merge this please???? @sespindola

Meleeman01 commented 3 years ago

lol is there a way i can participate in this? otherwise i'll gladly fork this as i've been looking for a node.js implementation of irc