Error if set logo - Githubissues

BadKiko commented 1 year ago

If i set logo from DrawableSource.Resource it crash my app, if i set DrawableSource.Empty all ok I convert drawable to bitmap and it throw me error if i set logo Logs: java.lang.IllegalArgumentException: width and height must be > 0 at android.graphics.Bitmap.createBitmap(Bitmap.java:1111) at android.graphics.Bitmap.createBitmap(Bitmap.java:1078) at android.graphics.Bitmap.createBitmap(Bitmap.java:1028) at android.graphics.Bitmap.createBitmap(Bitmap.java:989) at androidx.core.graphics.drawable.DrawableKt.toBitmap(Drawable.kt:68) at com.github.alexzhirkevich.customqrgenerator.style.BitmapScale$FitXY.scale(BitmapScale.kt:33) at com.github.alexzhirkevich.customqrgenerator.vector.QrCodeDrawableImpl.resize(QrCodeDrawableImpl.kt:369) at com.github.alexzhirkevich.customqrgenerator.vector.QrCodeDrawableImpl.setBounds(QrCodeDrawableImpl.kt:128) at androidx.core.graphics.drawable.DrawableKt.toBitmap(Drawable.kt:72) at androidx.core.graphics.drawable.DrawableKt.toBitmap$default(Drawable.kt:46)

Code(Jetpack Compose used): val data = QrData.Text(curSchedule?.JoinCode.toString()) val options = QrVectorOptions.Builder() .setPadding(.3f) .setErrorCorrectionLevel(QrErrorCorrectionLevel.High) .setLogo( QrVectorLogo( drawable =drawable, ) ) .setShapes( QrVectorShapes( darkPixel = QrVectorPixelShape .RoundCorners(.5f), ball = QrVectorBallShape .RoundCorners(.25f), frame = QrVectorFrameShape .RoundCorners(.25f), ) ) .build() val drawable = QrCodeDrawable(context, data, options) Image( bitmap = drawable.toBitmap(1024, 1024).asImageBitmap(), contentDescription = "qrCode", modifier = Modifier .fillMaxSize() )

alexzhirkevich commented 1 year ago

Try this accompanist library to convert drawable to compose painter

BadKiko commented 1 year ago

I try it before write this issue it doesn't work, but i doesnt test it without logo

alexzhirkevich commented 1 year ago

Can you share the image you use for a logo?

BadKiko commented 1 year ago

Cant find svg, xml:

BadKiko commented 1 year ago

BadKiko commented 1 year ago

doesnt work with rememberDrawablePainter, image is empty in card

code:

@Composable fun ShowQRJoinCode() { val context = LocalContext.current val data = QrData.Text(curSchedule?.JoinCode.toString()) val options = QrVectorOptions.Builder() .setErrorCorrectionLevel(QrErrorCorrectionLevel.High) .setColors( QrVectorColors( dark = QrVectorColor.Solid(MaterialTheme.colors.secondary.toStandardColor()), ball = QrVectorColor.Solid(MaterialTheme.colors.secondary.toStandardColor()), frame = QrVectorColor.Solid(MaterialTheme.colors.primary.toStandardColor()) ) ) .setBackground(QrVectorBackground()) .setShapes( QrVectorShapes( darkPixel = QrVectorPixelShape .RoundCorners(.5f), ball = QrVectorBallShape.Circle(1f), frame = QrVectorFrameShape .RoundCorners(.25f), ) ) .build() val qrDrawable = QrCodeDrawable(context, data, options) Card( shape = RoundedCornerShape(15.dp), contentColor = MaterialTheme.colors.background, backgroundColor = MaterialTheme.colors.background, border = BorderStroke(1.dp, MaterialTheme.colors.primary), modifier = Modifier.padding(horizontal = 30.dp, vertical = 0.dp) ) { Column() { Image( painter = rememberDrawablePainter(drawable = qrDrawable), contentDescription = "qrCode", modifier = Modifier.padding(30.dp) ) } } }

alexzhirkevich commented 1 year ago

doesnt work with rememberDrawablePainter, image is empty in card

code:

You didn't set up a logo in your last code example

Works as expected with rememberDrawablePainter.

val code = QrCodeDrawable(
    context,
    { "Hello world" },
    createQrVectorOptions {
        background {
            color = QrVectorColor.Solid(Color.GRAY)
        }
        errorCorrectionLevel = QrErrorCorrectionLevel.High
        logo {
            size = .25f
            shape = QrVectorLogoShape.Circle
            padding = QrVectorLogoPadding.Natural(.05f)
            drawable = DrawableSource.Resource(R.drawable.img)
        }
    }
)

Box(modifier = Modifier.fillMaxSize()) {
    Image(
        modifier = Modifier.size(300.dp)
            .align(Alignment.Center),
        painter = rememberDrawablePainter (code),
        contentDescription = ""
    )
}

Your logo is white and invisible on white background

alexzhirkevich commented 1 year ago

If you still have issues with rememberDrawablePainter you can use AndroidView


AndroidView(
  factory = {
      ImageView(it)
  },
  update = {
      it.setImageDrawable(code)
  }
)

alexzhirkevich commented 1 year ago

From 1.5.5 Drawable QR codes can be safely converted to Bitmap and used as Compose ImageBitmap

alexzhirkevich / custom-qr-generator

Error if set logo #10