alexzielenski / Mousecape

Cursor Manager for OSX
http://www.alexzielenski.com
Other
1.39k stars 166 forks source link

M1 version please #172

Open Bellavene opened 2 years ago

Bellavene commented 2 years ago

Please somebody compile an M1 version. Memory leaks by windowserver with the intel version.

alexzielenski commented 2 years ago

I'm not sure compiling for M1 would solve any memory leaks. Unfortunately I have no such machine to test with 😢 .

Would accept community contribution which addresses this.

VisualisationExpo commented 2 years ago

Can an Intel Mac build from source and produce a M1 build? Then I can try building (within the last two days I've downloaded both the latest source looked into the requirements for building for arm - something to do with arm64e and arm64 being present in the build config)

Bellavene commented 2 years ago

As I know you can build for any platform, but I don't know how.

alexzielenski I can test it for you

VisualisationExpo commented 2 years ago

I've just built Mousecape locally and it shows up as being Universal, however the Sparkle framework doesn't come with.

Mousecape works and installing the Mousecape Helper also works.

I wonder why that is. For now it's 3,3 MB vs 6,something MB previously. Probably due to the missing Sparkle framework?!

edit: I see that the Sparkle framework isn't even included in the Mousecape-master folder.. Perhaps I can borrow from the Mousecape release version... I'll try that

From Appletoolbox.com

Universal. You’ll only see this label if you’re running a non-M1 Mac. It means that an app has been optimized for ARM, but since you aren’t running the M1 chip, it’s running “universally” on Intel.

VisualisationExpo commented 2 years ago

Update.. re-built again, but no success on having Check for Updates working .. I've included the Sparkle framework from the 1813 release version, but the mechanism won't take.

I saw some issues in one place that I will see to - it's probably what's the matter.

Bellavene commented 2 years ago

Thank you for trying! I believe that the framework may also needed to be universal

fnankivell commented 2 years ago

Any news on the M1 effort? Thank you!

VisualisationExpo commented 2 years ago

Note. I built this Mousecape version for macOS 12 and up I hope that it works.. I built it while selecting to build for Intel and Apple Silicon on my Intel Mac with Xcode 13.3.1

Here's an Apple Silicon and Intel version of Mousecape - version 1815 without the Sparkle framework. Sparkle framework doesn't like me. And I have no idea on how to make it work. Mousecape.zip

Bellavene commented 2 years ago

Thank you

Dnilo commented 2 years ago

Note. I built this Mousecape version for macOS 12 and up I hope that it works.. I built it while selecting to build for Intel and Apple Silicon on my Intel Mac with Xcode 13.3.1

Here's an Apple Silicon and Intel version of Mousecape - version 1815 without the Sparkle framework. Sparkle framework doesn't like me. And I have no idea on how to make it work. Mousecape.zip

I will be testing this in a couple of days when I get my mew mac with m1, in the meantime it shows as it can't run on my current intel mac. I'm still running Mouscape 0.0.6 (1714).

VisualisationExpo commented 2 years ago

Note. I built this Mousecape version for macOS 12 and up I hope that it works.. I built it while selecting to build for Intel and Apple Silicon on my Intel Mac with Xcode 13.3.1 Here's an Apple Silicon and Intel version of Mousecape - version 1815 without the Sparkle framework. Sparkle framework doesn't like me. And I have no idea on how to make it work. Mousecape.zip

I will be testing this in a couple of days when I get my mew mac with m1, in the meantime it shows as it can't run on my current intel mac. I'm still running Mouscape 0.0.6 (1714).

Is it impossible for you to even get the official 1813 release of Mousecape going on your Intel Mac? What model Mac is it, and how far back are you with macOS releases? Mojave?

VisualisationExpo commented 2 years ago

Thank you

You're welcome. How is it working for you?

note that I'm working in the dark with regards to Apple Silicon processors I just thought it would be great to finally put actions to my earlier words

Dnilo commented 2 years ago

Note. I built this Mousecape version for macOS 12 and up I hope that it works.. I built it while selecting to build for Intel and Apple Silicon on my Intel Mac with Xcode 13.3.1 Here's an Apple Silicon and Intel version of Mousecape - version 1815 without the Sparkle framework. Sparkle framework doesn't like me. And I have no idea on how to make it work. Mousecape.zip

I will be testing this in a couple of days when I get my mew mac with m1, in the meantime it shows as it can't run on my current intel mac. I'm still running Mouscape 0.0.6 (1714).

Is it impossible for you to even get the official 1813 release of Mousecape going on your Intel Mac? What model Mac is it, and how far back are you with macOS releases? Mojave?

It's not impossible, but I haven't had the need to check for any updates for Mousecape, I just noticed there was a new version hehe. I came back to the github looking for M1 experiences and to know what to prepare for.

I have a Mac Mini late 2014 with Big Sur.

Bellavene commented 2 years ago

It is working quite well

VisualisationExpo commented 2 years ago

That's lovely.. Perhaps I should just fork the project properly.. I'll have to ask the author, Alex, about the issue with Sparkle and if I can fork and then exclude that framework

Dnilo commented 2 years ago

I can also confirm it's working flawlessly on m1, thank you.

VisualisationExpo commented 2 years ago

So, just to ask in broader terms. The Windowserver issue leaking memory has been eliminated when using an Apple Silicon Mac and the Mousecape build I uploaded to this thread? 😬

Asking because as you know, I'm on an Intel Mac still and I can read that the author of Mousecape in https://github.com/alexzielenski/Mousecape/issues/172#issuecomment-1017677762 doesn't think that re-compiling for M1 helps.

It's only good if it has helped. That will surely help moving forward. 👍🏻

Bellavene commented 2 years ago

The window server issue was mostly managed about two minor macos updates ago. Thank you very much, this was the last non-native app I had in last 6 months. I don't know for what is "sparkle" for, everything works. Definitely it can be released in this state.

Mammadbayli commented 2 years ago

is 1815 safe to use on M1?

VisualisationExpo commented 2 years ago

is 1815 safe to use on M1?

There honestly shouldn't be an issue with it. :) Virus Total results if those matter. https://www.virustotal.com/gui/file/197a9457ecc7435351df8206a329e3468d3e9a69140792deffe17e5775488a9a?nocache=1

VisualisationExpo commented 2 years ago

The window server issue was mostly managed about two minor macos updates ago. Thank you very much, this was the last non-native app I had in last 6 months. I don't know for what is "sparkle" for, everything works. Definitely it can be released in this state.

Sparkle handles the update to a newer version via an easy to use interface that you've probably seen in many other apps - this particular build is without that framework because I am not smart enough to include it in a way that @alexzielenski can for instance. And because the Sparkle framework would have to be built for M1 too - I got stuck right there - choosing to exclude it from the build and hoping that an official build of Mousecape comes out is what I thought was The Right Thing™ at the time

Dnilo commented 2 years ago

Had to come back to inform that while it works, it's animating the cursors with the wrong frame duration (very slow in my case). I reverted to the 1813 version, it's not native but it makes zero impact on my cpu usage, specially since I apply the cape and close mousecape afterwards.

I don't know what process keeps the cursor applied and animating but besides all the processes I usually run there's no other process that uses more than 0.1% of CPU when it's applied vs default Mac cursor.

I'm on a Mac Mini M1.

Bellavene commented 2 years ago

It is possible, I don't have any custom animated cursor set up

VisualisationExpo commented 2 years ago

@Dnilo I guess there's then no real reason to keep my build up. I so wish I had an M1 Mac of sorts to be with all the cool guys. It really was just a test, if you will, to see it it would bear fruit to compile for M1. It might also be that there's a more specific setting or build process in Xcode that would help eliminate the issue you are seeing.

elipongr commented 2 years ago

Hey @VisualisationExpo i installed 1815 but the cursor works only until i make one click, what have i done wrong?

VisualisationExpo commented 2 years ago

Hey @VisualisationExpo i installed 1815 but the cursor works only until i make one click, what have i done wrong?

I doubt you've done anything wrong.. best to try and install the Helper tool if you haven't already?

The issue comes and goes with me too - also with the official 1813

Dnilo commented 2 years ago

@Dnilo I guess there's then no real reason to keep my build up. I so wish I had an M1 Mac of sorts to be with all the cool guys. It really was just a test, if you will, to see it it would bear fruit to compile for M1. It might also be that there's a more specific setting or build process in Xcode that would help eliminate the issue you are seeing.

@alexzielenski @VisualisationExpo How can I help to make a build on Apple silicon?

ryenus commented 2 years ago

Maybe use GitHub Actions for the M1 build?