search

alexzielenski / ThemeEngine

OS X App to edit compiled .car files
BSD 2-Clause "Simplified" License
747 stars 130 forks source link

Fix for Big Sur crash #63

Open jslegendre opened 4 years ago

jslegendre commented 4 years ago

In TKMutableAssetStorage.m add:

- (BOOL)caAllowSubimageOfImage:(CGImageRef)image {
    return YES;
}
ghost commented 4 years ago

Thanks! I've been unable to figure that out myself. I would build ThemeEngine and eventually get an NSException and TKMutableAssets would always be there as an error.

Should be fun trying on Big Sur now.

Hmm - didn't quite work as expected for me. Have you made it compile and being able to open a .car file and not just the Welcome window?

jslegendre commented 4 years ago

Yes, I can open/browse .car files with this. Is it still crashing for you?

ghost commented 4 years ago

Yes,

I get this: libsystem_kernel.dylibmach_msg_trap: 0x7fff6d98bf64 <+0>: movq %rcx, %r10 0x7fff6d98bf67 <+3>: movl $0x100001f, %eax ; imm = 0x100001F 0x7fff6d98bf6c <+8>: syscall -> 0x7fff6d98bf6e <+10>: retq
0x7fff6d98bf6f <+11>: nop
`

the -> 0x7fff6d98bf6e <+10>: retq has a green description that reads Thread 1: signal SIGCONT

jslegendre commented 4 years ago

Sounds like you have a breakpoint set... Try running ThemeEngine without Xcode

ghost commented 4 years ago

Much better ! :D Thanks. Now I can get to see what changes I can make to Big Sur. There are so many .car files that needs some finding out this time around

ghost commented 4 years ago

Too bad that I can't save any .car files on Big Sur... I installed Big Sur using csrutil authenticated-root disable and csrutil disable - that still hasn't made a difference. I also mounted( I think) all the volumes and changes permissions on the .car file I want to change. Yet, ThemeEngine doesn't respond to Save commands. Perhaps adding ThemeEngine to the Full Disk Access list would help. Edit.. no, didn't help adding ThemeEngine to the Full Disk Access list.

jslegendre commented 4 years ago

Try restarting Finder. In terminal type killall Finder

yonigold1 commented 4 years ago

In TKMutableAssetStorage.m add:

- (BOOL)caAllowSubimageOfImage:(CGImageRef)image {
    return YES;
}

Would someone be able to build it to an app for me with that change as I am only a graphic designer and editing/building an app is a whole new world for me. it would be greatly appreciated 👉👈

yonigold1 commented 4 years ago

Would someone be able to compile it for me?

jslegendre commented 4 years ago

@yonigold1 I have made a fork of this project and included a notarized release. https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(112)

@MUI68K My fork contains instructions on how to remount the system volume as read/write. I have included various fixes as well as some support for the new glyphs (SF Symbols) on Big Sur and 'Receive from Editor' is also working now. https://github.com/jslegendre/ThemeEngine

ghost commented 4 years ago

@jslegendre Thanks! I see that you mention that Receive from Editor is working again.

@mbert and I spoke about(didn't get any further) multiple Send to Editor and the same for Receive from Editor back when he initially pulled in my before-mentioned "non-fixes" to the way of enumerating assets and the silly scrolling. Examples such as; Send to Sketch Send to Affinity Photo Send to Affinity Designer

And of course the usual Adobe entries. Send to Editor worked fine but I seem to remember it taking Affinity Photo only and not Designer - if both were installed. Receive from Editor never worked despite all my attempts in re-writing some of the script handling the AppleScript sending and receiving. I would think Acorn 6 would have full scripting, but I never got that far myself.

Great seeing Receive from Editor working again.

Thank you for the detailed explanation on Big Sur read/write access. I hope @alexzielenski sees this.

yonigold1 commented 4 years ago

Hey so I just want to thank you for doing that!!! and just a little issue I noticed in the app is that it doesn't save any of the edits I made to the .car file I've tried multiple times and can't seem to get it to work

@yonigold1 I have made a fork of this project and included a notarized release. https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(112)

@MUI68K My fork contains instructions on how to remount the system volume as read/write. I have included various fixes as well as some support for the new glyphs (SF Symbols) on Big Sur and 'Receive from Editor' is also working now. https://github.com/jslegendre/ThemeEngine

jslegendre commented 4 years ago

@yonigold1 I was getting that problem too but seemed to depend on the file and what edits were made. Issue has been fixed, check out the latest release

yonigold1 commented 4 years ago

im still expeirencing the issue so here let me get at what im trying to do/theme because maybe that can help to fix it. So im trying to theme the Domino's app on iOS because it looks like it was made for iOS 6. So the very first thing i tried to change was the app background but it doesnt seem to save. ill attach the assets.car so you can try your self (im just replacing the background with a white image) Assets.zip

jslegendre commented 4 years ago

@yonigold1 Yep, seems to be a problem with .jpg assets because the png files I tried worked fine. Will continue to investigate.

yonigold1 commented 4 years ago

thank you so much for your time i really appreciate it !

ghost commented 4 years ago

@jslegendre How come the names in the sidebar list are truncated? It's not a major issue as I can quickly find out what's what. What's your thought on my suggestions with having multiple Send to Editor and Receive from Editor? Currently I of course can't use any of these commands as they depend on Adobe's apps.

jslegendre commented 4 years ago

@yonigold1 Turns out the issue was a little more complicated than I thought it would be but it's fixed now.

@MUI68K I will be switching to Sketch for sending/receiving

hatsune-miku commented 4 years ago

Thank you!

mbert commented 3 years ago

@yonigold1 I have made a fork of this project and included a notarized release. https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(112)

@MUI68K My fork contains instructions on how to remount the system volume as read/write. I have included various fixes as well as some support for the new glyphs (SF Symbols) on Big Sur and 'Receive from Editor' is also working now. https://github.com/jslegendre/ThemeEngine

Thank you very much for this! Since there's no "issues" section in your fork, is it possible to re-enable SIP after having replaced .car files? On Catalina I would usually boot into maintenance mode after my modification and run csrutil enable, so would I do csrutil authenticated-root enable; csrutil enable on Big Sur when done? Or can't I because after my modification the system volume is no longer original?

jslegendre commented 3 years ago

Or can't I because after my modification the system volume is no longer original?

I believe that is the case. You may be able to have authenticated-root disabled with normal SIP enabled but I haven’t tried

mbert commented 3 years ago

Thank you. Since Apple is making theming increasingly difficult I am tempted to leave my .car files alone for now. Overall the OS doesn't look bad. Only the 2d traffic light buttons bother me.

nsklaus commented 3 years ago

would it be possible to use this project to restore macOS theme to what it was prior to the Big Sur update ? possibly take all the car files from a previous release (Catalina) and apply them to Big Sur ? I really dislike the new cosmetic changes apple have done. especially the window title bar height, tool bar and tool bar icons. that flat design is bad.

yonigold1 commented 3 years ago

Hey is anyone else not able to save their edits to the car file? when I press save it just doesn't save, save as doesn't work either. Perhaps in the fork this can be fixed

grafikartes commented 3 years ago

Hey is anyone else not able to save their edits to the car file? when I press save it just doesn't save, save as doesn't work either. Perhaps in the fork this can be fixed

resolved with the latest version v1.0.0(114): https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(114)

ghost commented 3 years ago

Hey is anyone else not able to save their edits to the car file? when I press save it just doesn't save, save as doesn't work either. Perhaps in the fork this can be fixed

resolved with the latest version v1.0.0(114): https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(114)

Exactly !

quangka commented 3 years ago

Thank ? I will test it now

Vào Th 7, 28 thg 11, 2020 lúc 03:59 Allan Nyholm Nielsen < notifications@github.com> đã viết:

Hey is anyone else not able to save their edits to the car file? when I press save it just doesn't save, save as doesn't work either. Perhaps in the fork this can be fixed

resolved with the latest version v1.0.0(114): https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(114)

Exactly !

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/alexzielenski/ThemeEngine/issues/63#issuecomment-734988470, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP464RR2YN5DIH6HTHJQKATSSAHLZANCNFSM4QD2ZF3A .

quangka commented 3 years ago

Is it possible to program themeEngine to work on Ios?

Vào Th 7, 28 thg 11, 2020 lúc 07:39 Quang Buii quanga317@gmail.com đã viết:

Thank ? I will test it now

Vào Th 7, 28 thg 11, 2020 lúc 03:59 Allan Nyholm Nielsen < notifications@github.com> đã viết:

Hey is anyone else not able to save their edits to the car file? when I press save it just doesn't save, save as doesn't work either. Perhaps in the fork this can be fixed

resolved with the latest version v1.0.0(114): https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(114)

Exactly !

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/alexzielenski/ThemeEngine/issues/63#issuecomment-734988470, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP464RR2YN5DIH6HTHJQKATSSAHLZANCNFSM4QD2ZF3A .

quangka commented 3 years ago

Hepplme

Vào Th 7, 28 thg 11, 2020 lúc 12:21 Quang Buii quanga317@gmail.com đã viết:

Is it possible to program themeEngine to work on Ios?

Vào Th 7, 28 thg 11, 2020 lúc 07:39 Quang Buii quanga317@gmail.com đã viết:

Thank ? I will test it now

Vào Th 7, 28 thg 11, 2020 lúc 03:59 Allan Nyholm Nielsen < notifications@github.com> đã viết:

Hey is anyone else not able to save their edits to the car file? when I press save it just doesn't save, save as doesn't work either. Perhaps in the fork this can be fixed

resolved with the latest version v1.0.0(114): https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(114)

Exactly !

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/alexzielenski/ThemeEngine/issues/63#issuecomment-734988470, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP464RR2YN5DIH6HTHJQKATSSAHLZANCNFSM4QD2ZF3A .

ghost commented 3 years ago

@quangka

Is it possible to program themeEngine to work on Ios?

You can edit the iOS .car files by extracting them from iOS onto the Mac and then edit using ThemeEngine. This all requires Jailbreaking you iOS device from what I've heard.

I'm not certain if there's any plans on bringing ThemeEngine over to iOS.

quangka commented 3 years ago

I got an error when opening Assets on mac

Vào Th 7, 28 thg 11, 2020 lúc 20:21 Allan Nyholm Nielsen < notifications@github.com> đã viết:

@quangka https://github.com/quangka

Is it possible to program themeEngine to work on Ios?

You can edit the iOS .car files by extracting them from iOS onto the Mac and then edit using ThemeEngine. This all requires Jailbreaking you iOS device from what I've heard.

I'm not certain if there's any plans on bringing ThemeEngine over to iOS.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/alexzielenski/ThemeEngine/issues/63#issuecomment-735230550, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP464RSQSRZUBQUVU5YS5H3SSD2O7ANCNFSM4QD2ZF3A .

quangka commented 3 years ago

Vào Th 7, 28 thg 11, 2020 lúc 20:41 Quang Buii quanga317@gmail.com đã viết:

I got an error when opening Assets on mac

Vào Th 7, 28 thg 11, 2020 lúc 20:21 Allan Nyholm Nielsen < notifications@github.com> đã viết:

@quangka https://github.com/quangka

Is it possible to program themeEngine to work on Ios?

You can edit the iOS .car files by extracting them from iOS onto the Mac and then edit using ThemeEngine. This all requires Jailbreaking you iOS device from what I've heard.

I'm not certain if there's any plans on bringing ThemeEngine over to iOS.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/alexzielenski/ThemeEngine/issues/63#issuecomment-735230550, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP464RSQSRZUBQUVU5YS5H3SSD2O7ANCNFSM4QD2ZF3A .

ghost commented 3 years ago

@quangka What's the error you're getting? Are you using macOS Big Sur or macOS Catalina?

You might have to use a different build of ThemeEngine for when on macOS Catalina. I can help with that.

yonigold1 commented 3 years ago

Hey is anyone else not able to save their edits to the car file? when I press save it just doesn't save, save as doesn't work either. Perhaps in the fork this can be fixed

resolved with the latest version v1.0.0(114): https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(114)

It still wont work for me

ghost commented 3 years ago

Hey is anyone else not able to save their edits to the car file? when I press save it just doesn't save, save as doesn't work either. Perhaps in the fork this can be fixed

resolved with the latest version v1.0.0(114): https://github.com/jslegendre/ThemeEngine/releases/tag/v1.0.0(114)

It still wont work for me

Have you done all the steps for editing .car files on Big Sur as described on the page here ? https://github.com/jslegendre/ThemeEngine/blob/v3/README.md

I initially faced the same issue until I learned the correct way on how to edit the files.

tcptps commented 3 years ago

Or can't I because after my modification the system volume is no longer original?

I believe that is the case. You may be able to have authenticated-root disabled with normal SIP enabled but I haven’t tried

MAIN QUESTION Has any body tried this yet ?

Side Questions: Am I right on those assumptions ? And is it mandatory to disable because I use FileVault and it currently won’t let me disable authenticated-root because of it. YES it is ! Does anybody know FileVault works at all with authenticated-root disabled ? NO! but YES on T2 ? Post about authenticated-root A Thread about It And another Thread Any help is very much appreciated.

Something I didn’t understand but seems useful