alexziskind1 / nativescript-oauth

Other
35 stars 53 forks source link

Support multiple instances #55

Open chilltemp opened 7 years ago

chilltemp commented 7 years ago

Right now index.ts has a bunch of functions/variables that are static. This prevents us from having multiple instances of oauth at once. My problem is that it makes unit testing harder, but what if someone was coding to multiple auth providers? (I know it would be better for a single provider with federation to others. This is just a what-if.)

alexziskind1 commented 7 years ago

Definitely. This is something I’ve been wanting to do for a little while now, but haven’t had a chance yet.

On Sep 22, 2017, at 2:31 PM, chilltemp notifications@github.com wrote:

Right now index.ts has a bunch of functions/variables that are static. This prevents us from having multiple instances of oauth at once. My problem is that it makes unit testing harder, but what if someone was coding to multiple auth providers? (I know it would be better for a single provider with federation to others. This is just a what-if.)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/alexziskind1/nativescript-oauth/issues/55, or mute the thread https://github.com/notifications/unsubscribe-auth/ABkAswAP7MfRHyV__3NTOYTs5o-Yvlq-ks5sk_zugaJpZM4PhE5M .