alexziskind1 / nativescript-oauth

Other
35 stars 53 forks source link

tns-oauth-webview Issue when updating to NativeScript 5.0 #95

Open bbarne8 opened 6 years ago

bbarne8 commented 6 years ago

After updating to NativeScript 5.0, the login process has started failing to complete. The WebView loads and I am able to sign in, but after submitting the login nothing else happens.

The checkCodeIntercept callback is never getting called as none of the WKNavigationDelegate calls on TnsOAuthWebViewHelper appear to be triggered after login submission. In the WebView from the tns-core-modules, the webViewDecidePolicyForNavigationActionDecisionHandler is being called after the login click and is giving a navigationAction of formSubmitted. The webViewDidFinishNavigation is also being called here, but nothing is coming back for the tns-oauth-webview-helper.ios calls.

Is there anything being done or planned to support NativeScript 5?

alexziskind1 commented 6 years ago

Hi Ben.

This plugin is discontinued. Please use the new plugin called NativeScript-oauth2

Alex

On Nov 12, 2018, at 4:36 PM, Ben Barnes notifications@github.com wrote:

After updating to NativeScript 5.0, the login process has started failing to complete. The WebView loads and I am able to sign in, but after submitting the login nothing else happens.

The checkCodeIntercept callback is never getting called as none of the WKNavigationDelegate calls on TnsOAuthWebViewHelper appear to be triggered after login submission. In the WebView from the tns-core-modules, the webViewDecidePolicyForNavigationActionDecisionHandler is being called after the login click and is giving a navigationAction of formSubmitted. The webViewDidFinishNavigation is also being called here, but nothing is coming back for the tns-oauth-webview-helper.ios calls.

Is there anything being done or planned to support NativeScript 5?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

bbarne8 commented 6 years ago

Hi Ben. This plugin is discontinued. Please use the new plugin called NativeScript-oauth2 Alex

Thanks Alex,

I found the new plugin and implemented it as well. I am experiencing a similar issue right now. I'm not sure if it is still related to the new version of NativeScript, as I see that you have updated the new plugin to use the the tns-core-modules@5.0.0 but they have not been published in a new npm version.

Do you have any idea when a 1.1.1 release may be coming for that plugin.

For now, I downgraded my platform to 4.2.0 and this plugin(nativescript-oauth) works again, but the new nativescript-oauth2 still did not work.

This may be related to something else and not an issue with the new plugin. I am just experiencing the same issue as with this plugin and wanted to wait until the nativescript-oauth2@1.1.1 was released to see if that fixed the issue.

Do you know if the next release of nativescript-oauth2 will address the issues to the WebView login submission process for Nativescript 5 or is that not a known issue at this point?

alexziskind1 commented 6 years ago

Thanks for letting me know - just pushed that change to npm. Please try it out