Support for next nativescript release

[funder7]

Hi,

Recently the nativescript team has started to update basically all their packages. That is particularly important if you are using Angular >= 9 because it let's you benefit of various new features, one of them the new ng compiler.

Unfortunately I was not able to use the current version of this plugin, but with some little changes it can be compiled with typescript@3.9 and so become compatible with new nativescript build toolchain (which is still under development, stable release should be published in the next days, from what I read).

I've forked the project and pushed the changes, I don't know if the author of this plugin has some time to review them and in case merge with the actual version, just for the people who need a working version and can't wait for the official ns packages to be released.

Unfortunately I've tried to launch tests but there are changes also on that side, so before to continue and fix them too, let's check what @alexziskind1 thinks about it :-)

Cheers

[alexziskind1]

Thanks Federico. This plugin needs help from folks like yourself. I got it off to a good start, but it deserves to be cared for, much better than I have done recently. If you have a PR, I will gladly accept it. If you want to be a more permanent contributor, then let me know as well.

On Jul 16, 2020, at 10:39 AM, Federico Ricchiuto notifications@github.com wrote:

 Hi,

Recently the nativescript team has started to update basically all their packages. That is particularly important if you are using Angular >= 9 because it let's you benefit of various new features, one of them the new ng compiler.

Unfortunately I was not able to use the current version of this plugin, but with some little changes it can be compiled with typescript@3.9 and so become compatible with new nativescript build toolchain (which is still under development, stable release should be published in the next days, from what I read).

I've forked the project and pushed the changes, I don't know if the author of this plugin has some time to review them and in case merge with the actual version, just for the people who need a working version and can't wait for the official ns packages to be released.

Unfortunately I've tried to launch tests but there are changes also on that side, so before to continue and fix them too, let's check what @alexziskind1 thinks about it :-)

Cheers

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[funder7]

Thanks Federico. This plugin needs help from folks like yourself. I got it off to a good start, but it deserves to be cared for, much better than I have done recently. If you have a PR, I will gladly accept it. If you want to be a more permanent contributor, then let me know as well.

Hello Alex, nice to meet you! :-) I would be glad to give my contribute to this project, please consider that I'm not an oAuth2 expert, this project where I've used your plugin is the first for me, using OAuth security. I have to thank you and whoever contributed to the development, without this plugin I would have given up for sure, plus, I think that a lot of people it's using and beneficiate from it!

Said this, I would be glad to contribute, I'll probably be less busy with work after August.

Now I'll open the PR. After sending it, it's possible to make changes to the code, or another PR is required for that? I guess that this version I'm sending will need further changes before publishing.

I wasn't able to run tests due to the latests updates introduced in the build toolchain. I'm curious about a point which is related to tests... since when I downloaded ns-oauth2 the first time, I noticed that the install cmd is npm install ... instead of tns plugin add .... There's a reason behind this choice or it's casual? I'm asking, because when I've tried to update the project test config (there's a cmd for that apparently), it returned something like "no valid nativescript project found". If you can give me any info on this topic, that would save me time with the migration :-)

I've just sent the PR, I hope that it's editable, otherwise I will open a new one, no problem!

See you later ;)