Nativescript 7.x support

funder7 commented 4 years ago

What is the current behavior?

The plugin is not usable inside a NativeScript project using Angular version >= 9

What is the new behavior?

Dependencies have been updated in order to make the project compatible with typescript@3.9. Apparently this ts version is required to allow the import inside a Nativescript-Angular project which is using the new Ivy compiler since angular@9

Important notes

This code has been included, built, and run into an existing NS project. At runtime it showed some warnings, but all errors were solved.
Test configuration must be updated in order to make tests runnable again, don't mark this code as "stable" before enabling tests again.
This change: qsObj["code"] --> qsObj.code.toString() has been tested on Android and works, by the way some tests would be a nice to have.

Fixes #124 . Fixes #114 .

alexziskind1 commented 4 years ago

@funder7 thanks for the PR. is this backwards compatible with ns6?

funder7 commented 4 years ago

Hi @alexziskind1 actually this version is compatible with ns6, I made some confusion with versions :-)

I think that it's safer to merge this into a new branch, instead of master directly... Now I'm using it on Android, but I've got no chance to test in on iOS!

Some ns modules have been updated in the meanwhile, I'm going to test & commit the update.

We could name this version 2.5.0-rc.0, then once N team releases stable modules, this can be consolidated and released too. What do you think about it?

bastienlemaitre commented 4 years ago

https://github.com/NativeScript/nativescript-angular/issues/2222

alexziskind1 commented 3 years ago

Thanks for the PR. I'm going to close this out as I've done the update separately on a live stream so more folks could benefit (i hope). But I appreciate your contribution

alexziskind1 / nativescript-oauth2