search

alexziskind1 / nativescript-oauth2

Other
86 stars 93 forks source link

fix issue #116 #131

Closed Burgov closed 4 years ago

Burgov commented 4 years ago

See #116

I think this PR should do the trick but I'm not 100% sure how to test it.

@alexziskind1 can you verifiy?

alexist commented 4 years ago

To reproduce the issue, you juste have to put page router outlet inside à layout : 

<GridLayout rows="1"
            columns="1">
    <page-router-outlet></page-router-outlet>
</GridLayout>

With current version of this plugin, authentication with a TnsOaProvider (which delegate to SFSafariViewController), you will get a blank page in safari with the title "Website name"

alexziskind1 commented 4 years ago

Thank for the PR @Burgov.

Burgov commented 4 years ago

@alexziskind1 any chance you can create a new release on npm?

alexziskind1 commented 4 years ago

@alexziskind1 any chance you can create a new release on npm?

This is now published