fix tsconfig.json in angular demo - Githubissues

alexziskind1 / nativescript-oauth2

Other

86 stars 93 forks source link

fix tsconfig.json in angular demo #153

Open BBazard opened 3 years ago

BBazard commented 3 years ago

What is the current behavior?

When running tns build android, there is an error:

ERROR in ../src/tns-oauth-native-view-controller.ts:21:14 - error TS2339: Property 'browser' does not exist on type 'typeof androidx'.

21   ? androidx.browser?.customtabs

I think the error comes from the fact that the typescript file is not compiled into javascript because it is not included in tsconfig.json.

What is the new behavior?

No error.

How to reproduce?

ns --version: 7.0.11 node --version: v12.21.0

git clone https://github.com/BBazard/nativescript-oauth2 --branch fix-angular-demo-android fix
cd fix/demo-angular
tns build android # important
tns debug android

More info

Tested on android device.
The tns build android before the tns debug android is important to avoid the problem mentioned by https://github.com/alexziskind1/nativescript-oauth2/issues/141#issuecomment-738086773 aka "Application entry point file not found.".

Fixes #134 #141