After Google Signin my application doesn't close the frame of "google authenticator" and keep runing

kharratahmed commented 5 years ago

Make sure to check the demo app(s) for sample usage

Done

Make sure to check the existing issues in this repository

Done

Which platform(s) does your issue occur on?

-Android

emulator or device. What type of device? device

Please, provide the following version numbers that your issue occurs with:
CLI: 5.0.1
Cross-platform modules: 5.0.1
Runtime(s): 5.0.0

Plugin(s):

"dependencies": {
"@angular/animations": "6.1.10",
"@angular/common": "6.1.10",
"@angular/compiler": "6.1.10",
"@angular/core": "6.1.10",
"@angular/forms": "6.1.10",
"@angular/http": "6.1.10",
"@angular/platform-browser": "6.1.10",
"@angular/platform-browser-dynamic": "6.1.10",
"@angular/router": "6.1.10",
"@danvick/ngx-translate-nativescript-loader": "^2.0.0",
"@ngx-translate/core": "^11.0.1",
"@progress-nativechat/nativescript-nativechat": "2.0.3",
"kinvey-nativescript-sdk": "3.11.6",
"nativescript-accelerometer": "2.0.1",
"nativescript-angular": "6.2.0",
"nativescript-auto-fit-text": "^1.0.0",
"nativescript-background-http": "3.3.0",
"nativescript-camera": "4.0.3",
"nativescript-checkbox": "^3.0.3",
"nativescript-fancyalert": "^3.0.6",
"nativescript-fresco": "5.1.0",
"nativescript-geolocation": "4.3.1",
"nativescript-imagepicker": "6.0.4",
"nativescript-intl": "3.0.0",
"nativescript-iqkeyboardmanager": "1.3.0",
"nativescript-oauth2": "^1.1.3",
"nativescript-social-share": "1.5.1",
"nativescript-theme-core": "1.0.4",
"nativescript-toast": "^1.4.6",
"nativescript-ui-autocomplete": "3.10.1",
"nativescript-ui-calendar": "3.9.0",
"nativescript-ui-chart": "3.9.1",
"nativescript-ui-dataform": "3.7.4",
"nativescript-ui-gauge": "3.7.1",
"nativescript-ui-listview": "3.7.2",
"nativescript-ui-sidedrawer": "5.0.0",
"reflect-metadata": "0.1.12",
"rxjs": "6.2.2",
"rxjs-compat": "^6.1.0",
"tns-core-modules": "5.0.1",
"zone.js": "0.8.26"
},
"devDependencies": {
"@angular/compiler-cli": "~6.1.0",
"@ngtools/webpack": "^6.2.7",
"babel-traverse": "6.26.0",
"babel-types": "6.26.0",
"babylon": "6.18.0",
"lazy": "1.0.11",
"nativescript-dev-typescript": "0.7.2",
"nativescript-dev-webpack": "0.17.0",
"tns-platform-declarations": "4.2.0",
"typescript": "~2.7.2"
}

Please, tell us how to recreate the issue in as much detail as possible.

when i chose fb login all work fine but with google a new frame show then after login this frame dosen't close and keep runing my application there (so 2 instance of application) 1-click google signin button 2-finish google sign in process 3-frame dosen't close and run one more instance of my application

Is there any code involved?

AndroidManifest:

<application android:name="com.tns.NativeScriptApplication" android:allowBackup="true" android:icon="@drawable/icon" android:label="@string/app_name" android:theme="@style/AppTheme" android:launchMode="singleTask">
    <activity android:name="com.tns.NativeScriptActivity" android:label="@string/title_activity_kimera" android:configChanges="keyboardHidden|orientation|screenSize" android:theme="@style/LaunchScreenTheme">
        <meta-data android:name="SET_THEME_ON_LAUNCH" android:resource="@style/AppTheme" />
        <intent-filter>
            <action android:name="android.intent.action.MAIN" />
            <category android:name="android.intent.category.LAUNCHER" />
        </intent-filter>
        <intent-filter>
            <action android:name="android.intent.action.VIEW" />
            <category android:name="android.intent.category.DEFAULT" />
            <category android:name="android.intent.category.BROWSABLE" />
            <data android:path="/oauth2redirecte" android:scheme="com.googleusercontent.apps.xxxxxxxxxx-i1gr5u7a8ece75n6ibjso47c3a2bql05" />
        </intent-filter>
    </activity>
    <activity android:name="com.tns.ErrorReportActivity" />
</application>

Main.ts: platformNativeScriptDynamic().bootstrapModule(AppModule);
App.component.html: `
`

Login Component:

this.authService
      .OauthLoginToken(provider)
      .then((result: ITnsOAuthTokenResult) => { 
            console.log(result.accessToken);
            console.log("test");
                this.messages.push(this.translateService.instant('backendcode.'+422));  
    }).catch(()=>{
        this.errors.push(this.translateService.instant('backendcode.499'));
        });

Login service:

public async OauthLoginToken(providerType): Promise<ITnsOAuthTokenResult> {
this.client = new TnsOAuthClient(providerType);
return  new Promise<ITnsOAuthTokenResult>((resolve, reject) => {
   this.client.loginWithCompletion(
    (tokenResult: ITnsOAuthTokenResult, error) => {
      if (error) {
        console.log("reject");
        reject(error);
      } else {
        console.log("resolve");
        resolve(tokenResult);
      }
    }
  );
})
}

ChrisJohns-me commented 5 years ago

I could be wrong, but is it possible that the documentation is incorrectly directing you to add android:launchMode="singleTask" to the <application> tag, when it should be on the <activity> tag?

https://developer.android.com/guide/topics/manifest/activity-element

In your case,

<application ... android:launchMode="singleTask">
        <activity ...>

would become:

<application ...>
        <activity ... android:launchMode="singleTask">

this is what fixed it for me.

alexziskind1 commented 5 years ago

Thanks for the suggestion @ChrisJohns-me. Did this workaround work for you @kharratahmed ?

alexziskind1 / nativescript-oauth2