search

alexzorin / certbot-dns-multi

Certbot DNS plugin supporting multiple providers, using github.com/go-acme/lego
MIT License
49 stars 7 forks source link

IONOS Cleanup #11

Open jackc94 opened 7 months ago

jackc94 commented 7 months ago

It would be great if the TXT entry was cleaned up after the certs are issued... I know IONOS supports this through the API.

Looks like it might be thinning about it from the logs but the TXT entry remains...

2024-01-29 23:50:38,317:DEBUG:acme.client:Storing nonce: < nonce> 2024-01-29 23:50:38,318:DEBUG:certbot._internal.error_handler:Calling registered functions 2024-01-29 23:50:38,319:INFO:certbot._internal.auth_handler:Cleaning up challenges 2024-01-29 23:50:38,321:DEBUG:certbot_dns_multi._internal.dns_multi:Asking lego to clean up record <record> for domain <mydomain.co.uk>

alexzorin commented 7 months ago

If you can confirm that:

  1. lego by itself does the cleanup properly
  2. This plugin doesn't

I will be able to investigate.

Thanks.

jackc94 commented 7 months ago

Hi @alexzorin

Thanks for getting back to me so quickly. Ok... so I have tested this directly with lego and can confirm that it DOES NOT clean up so will raise an issue directly.

Thanks for your help,

Jack

jackc94 commented 7 months ago

Hey @alexzorin

So it looks like this was resolved in v4.15.0 of lego here https://github.com/go-acme/lego/pull/2083

Is this something you bundle with certbot-dns-multi? Apologies, not sure how these things work...

alexzorin commented 7 months ago

Thanks for figuring out the relevant issue.

I actually released a new version of the plugin yesterday that uses the latest release of lego (v4.15.0), so if you update, it should be working for you now.

If you use the snap, you might need to run snap refresh.

jackc94 commented 7 months ago

@alexzorin BINGO!

That's great news... looking forward to implementing this now.

Keep up the great work.