search

alezanai / kvs-parser

Kinesis Video Stream Parser Library in Node.js
GNU General Public License v3.0
3 stars 1 forks source link

feat: add unit-test for frame object #12

Closed dharmik-dalwadi-seaflux closed 2 years ago

piercus commented 2 years ago

@dharmik-dalwadi-seaflux this branch is failed, can you please fix it or comment to explain

dharmik-dalwadi-seaflux commented 2 years ago

@piercus Travis failing due to the bemcoder library. We need to install the dependencies on Travis which is required by beamcoder. See: https://app.travis-ci.com/github/alezanai/kvs-parser/builds/248517277#L220-L231

piercus commented 2 years ago

Can you do this or do you need help https://docs.travis-ci.com/user/installing-dependencies/

dharmik-dalwadi-seaflux commented 2 years ago

@piercus I have added the command in travis.yml but still getting the same error. Error : https://app.travis-ci.com/github/alezanai/kvs-parser/builds/248520708#L594-L602 Travis.yml : https://github.com/alezanai/kvs-parser/blob/DHA-frame-object-unit-test/.travis.yml

piercus commented 2 years ago

please try to set LD_LIBRARY_PATH or do echo $LD_LIBRARY_PATH to debug it.

You can still use the debug mode

dharmik-dalwadi-seaflux commented 2 years ago

Hello @piercus I have fixed the dependencies issue but got the strange error in npm test

Error: 

  Error: Module did not self-register: '/home/travis/build/alezanai/kvs-parser/node_modules/segfault-handler/build/Release/segfault-handler.node'.

Travis Link: https://app.travis-ci.com/github/alezanai/kvs-parser/jobs/564921358#L782

piercus commented 2 years ago

@dharmik-dalwadi-seaflux yes this is strange : can you please try to : A) change travis node version B) try to reproduce it in debug mode and try to understand what is happenning

dharmik-dalwadi-seaflux commented 2 years ago

Hello @piercus Do we need the frame-stream.js now? Becuase we are generating images from the iframe-stream.js. And for the above issue i am not able to found the root cause. but it get solved when i remove the one of the test file from the test/ folder.

A) Changing node version didn't still got error B) Able to reproduce the error locally but didn't find the root cause

piercus commented 2 years ago

If removing frame-stream.js solve teh issue, yes please remove it.

Please remove both the test file and the lib files

dharmik-dalwadi-seaflux commented 2 years ago

@piercus Travis got passed can you please review and merge this PR?