alf45tar / PedalinoMini

Wireless and Bluetooth MIDI Foot Controller
GNU General Public License v3.0
484 stars 84 forks source link

MIDI pedal finished product release & LED color issue #330

Closed bobvc133 closed 1 year ago

bobvc133 commented 2 years ago

This is my pedal! The latest sponsored version firmware has a problem with the LED color setting, it is set to red, but the actual display is green. QQ截图20220426205906 QQ截图20220426205858 QQ截图20220426205914 QQ截图20220426205749 QQ截图20220426205813 QQ截图20220426210155

mknerr commented 2 years ago

That's beautiful! Regarding your LED issue, I can't say for certain, but having worked with pixel strip before, I know the colors are not always addressed in the same order (ie., GRB, RGB, etc.), so you probably just need to tweak the code somewhere to adjust that. If you try to make them Red, do they turn green? @alf45tar, Perhaps an option could be added to the settings to make it easier to adjust. Probably not a big deal; you'd really only need to do this once.

bobvc133 commented 2 years ago

Yes, if you often need to modify the code to customize the settings, then it is meaningless to update the firmware through the browser, backup and restore the configuration file and other regular operations. Ordinary users basically cannot upgrade the firmware unless the firmware is a customized version. It is recommended to add custom settings such as the number of LEDs, vertically flip the screen, etc. to the WEB interface.

mknerr commented 2 years ago

Yeah, good point.

alf45tar commented 2 years ago

@bobvc133 it is amazing

alf45tar commented 2 years ago

That's beautiful! Regarding your LED issue, I can't say for certain, but having worked with pixel strip before, I know the colors are not always addressed in the same order (ie., GRB, RGB, etc.), so you probably just need to tweak the code somewhere to adjust that. If you try to make them Red, do they turn green? @alf45tar, Perhaps an option could be added to the settings to make it easier to adjust. Probably not a big deal; you'd really only need to do this once.

Did you try to change the following setting?

https://github.com/alf45tar/PedalinoMini/blob/93f915d08a022515a33ca77fab4e160ca2a61f90/src/Pedalino.h#L28

bobvc133 commented 2 years ago

That's beautiful! Regarding your LED issue, I can't say for certain, but having worked with pixel strip before, I know the colors are not always addressed in the same order (ie., GRB, RGB, etc.), so you probably just need to tweak the code somewhere to adjust that. If you try to make them Red, do they turn green? @alf45tar, Perhaps an option could be added to the settings to make it easier to adjust. Probably not a big deal; you'd really only need to do this once.

Did you try to change the following setting?

https://github.com/alf45tar/PedalinoMini/blob/93f915d08a022515a33ca77fab4e160ca2a61f90/src/Pedalino.h#L28

You can customize the settings by modifying the code, but I have to re-flash the machine. It is basically impossible to update the firmware through the browser. VS and PlatformIO sometimes have more problems. I hope that these custom items can be set in the WEB interface, and the flashing machine is simple. Just upgrade the firmware

alf45tar commented 2 years ago

Thanks @bobvc133 for the suggestion. I will try to add as much as possible every configuration parameters in the web interface with the next major release. Another planned improvement is to remove use of EEPROM and use only configuration files to avoid problem on version upgrade.

bobvc133 commented 2 years ago

Thanks @bobvc133 for the suggestion. I will try to add as much as possible every configuration parameters in the web interface with the next major release. Another planned improvement is to remove use of EEPROM and use only configuration files to avoid problem on version upgrade.

Looking forward to the new version of the firmware, thank you for your efforts!