alf45tar / PedalinoMini

Wireless and Bluetooth MIDI Foot Controller
GNU General Public License v3.0
479 stars 84 forks source link

Display mode and action suggestions #388

Closed bobvc133 closed 1 year ago

bobvc133 commented 1 year ago

It is recommended to set a switch to turn off the action display, because most hardware modes cannot support it. For example, when I use a resistance ladder, the screen can only display the first button loading, and it is often incomplete. Snipaste_2022-11-10_12-44-55

bobvc133 commented 1 year ago

Snipaste_2022-11-11_23-21-23 It is recommended to divide the Press action into two effects, one is the instantaneous effect and the other is the latch effect, so that the instantaneous button does not need to add the two actions of Press and Release, which can reduce the page layout space and reduce the difficulty of setting for users. After all, two actions have 4 values, 4 LED colors, and 4 labels.

alf45tar commented 1 year ago

On momentary button the most used action should be PRESS triggered immediately on press. RELEASE is not su useful. Replace PRESS with CLICK when you want to use DOUBLE PRESS or LONG PRESS because PRESS is triggered before every DOUBLE CLICK/LONG PRESS.

On latch button use PRESS and RELEASE or better I suggest to use CLICK. The CLICK behaviour on latch button is different. It corresponds to PRESS or RELEASE. Using CLICK you can reduce the numbers of duplicated actions.

Does it make sense?

bobvc133 commented 1 year ago

On momentary button the most used action should be PRESS triggered immediately on press. RELEASE is not su useful. Replace PRESS with CLICK when you want to use DOUBLE PRESS or LONG PRESS because PRESS is triggered before every DOUBLE CLICK/LONG PRESS.

On latch button use PRESS and RELEASE or better I suggest to use CLICK. The CLICK behaviour on latch button is different. It corresponds to PRESS or RELEASE. Using CLICK you can reduce the numbers of duplicated actions.

Does it make sense?

Maybe I didn't explain it clearly. Let me give an example. First of all, my button hardware is all momentary buttons. If I want to add a latch effect, I only need to add a Press action, but if you want to add a momentary effect, you must add a Press and a Release action, so you need to set the button, send, channel and CC options twice, and you need to test multiple times on 4 values, 4 LED colors and 4 labels to know the correct setting. If the Press action is divided into Two effects, one is the instantaneous effect, the other is the latch effect, you can avoid the above problems

Snipaste_2022-11-12_03-43-14

Snipaste_2022-11-12_04-11-46

alf45tar commented 1 year ago

Press event will change soon. The Press latch mode will be replaced by Step by Step action (version 3.0.6).

bobvc133 commented 1 year ago

Press event will change soon. The Press latch mode will be replaced by Step by Step action (version 3.0.6).

How to use the Step by Step action, I don’t understand, it seems to be different from what I expressed

alf45tar commented 1 year ago

On every event the Step by Step action execute the next action in list from a sequence. Execution start from first item in the sequence and return to begin on first empty action (circular list of non empty actions).

bobvc133 commented 1 year ago

On every event the Step by Step action execute the next action in list from a sequence. Execution start from first item in the sequence and return to begin on first empty action (circular list of non empty actions).

  • Define first action in the sequence with CC 0 and colour black
  • Define second action in the sequence with CC 127 and color light blue
  • Define a Click event to run the sequence Step by Step

I express the key point is that the momentary effect setting is a bit cumbersome ,the latch effect can be set with one PRESS action, but the momentary effect needs a PRESS and a RELEASE action. I hope that the latch and momentary effect can be set with only one PRESS action. My suggestion is Divide PRESS into two operation effects: PRESS MOMENTARY and PRESS LATCH,Users only need to configure one action, and can freely choose whether it is a latch or an momentary effect.

alf45tar commented 1 year ago

I cannot understand how you are planning to use the momentary switches. A momentary switch has only one stable state. For normally open switches it is the RELEASE state. PRESS is not stable.

Do you want to keep it pressed by your foot until you need a RELEASE action? Or you press it and release immediately?

Can you explain your real scenario? What should happen when you press it? With the current features a momentary switch can simulate a latch switch. A latch switch cannot simulate a momentary switch because to RELEASE it you have to press it.

bobvc133 commented 1 year ago

I cannot understand how you are planning to use the momentary switches. A momentary switch has only one stable state. For normally open switches it is the RELEASE state. PRESS is not stable.

Do you want to keep it pressed by your foot until you need a RELEASE action? Or you press it and release immediately?

Can you explain your real scenario? What should happen when you press it? With the current features a momentary switch can simulate a latch switch. A latch switch cannot simulate a momentary switch because to RELEASE it you have to press it.

What I have been talking about is the action configuration of the momentary switch. It has nothing to do with how the feet are operated. The current momentary effect action configuration has many duplicates and useless items, as shown in the blue and red marks in the picture below.

Snipaste_2022-12-21_14-00-22

My suggestion is as shown in the figure below, adding a PRESS+RELEASE operation, so that the configuration of the momentary effect action is much simpler and only occupies one layout position

Snipaste_2022-12-21_14-33-13

alf45tar commented 1 year ago

Now it is clear. You are asking to create a new action that combine Press and Release events in order to create a more short configuration.

This feature is similar to a keyboard key. Send Note On when pressed and Note Off when released. May I ask for what scenario you need it in a foot switch?

bobvc133 commented 1 year ago

Now it is clear. You are asking to create a new action that combine Press and Release events in order to create a more short configuration.

This feature is similar to a keyboard key. Send Note On when pressed and Note Off when released. May I ask for what scenario you need it in a foot switch?

My purpose is to make the configuration easier. I often made mistakes when configuring transient effects before. Because of duplicate items and useless items, I had to test for a long time before I could get the correct transient effect configuration. In daily use, some equipment and software control needs Instantaneous effects, such as switching timbres, some need one signal to trigger, and some need two signals of 0 and 127 to trigger,The LED lights up when you step on it, and turns off when you release it. Snipaste_2022-12-22_13-29-10 Snipaste_2022-12-22_13-34-32

Actions such as PRESS, RELEASE, CLICK, DOUBLE CLICK, LONG PRESS, REPEAT PRESSED and LONG RELEASED should have momentary effect. You can add a HOLD MODE function to achieve latch effects. Many software can simulate momentary switches as latch effects. However, the latch switch cannot be simulated as a momentary effect, while the actions of PedalinoMini are all latch effects

Snipaste_2022-12-22_13-51-29 Snipaste_2022-12-22_14-02-15

alf45tar commented 1 year ago

Press&Release has been implemented and it is under testing now. It will be released with next version 3.0.7.

bobvc133 commented 1 year ago

I found that just Press&Release still can't solve the similar transient effect problems I encountered, using the Repeat Pressed event, the LED will remain on, and the correct state should be blinking. Snipaste_2022-12-27_23-57-27

bobvc133 commented 1 year ago

It is recommended to delete the RELEASE and LONG RELEASED events of PedalinoMini. They are of little significance to exist alone. Change other events (PRESS, CLICK, DOUBLE CLICK, LONG PRESS, REPEAT PRESSED) to default instantaneous effects, and add a HOLD MODE option Simulate the self-locking effect, you will find that all events can control the instantaneous effect or self-locking effect, and the LED status can also find the correct setting, especially the increment or decrement action (BANK SELECT+, BANK SELECT-, PROGRAM CHANGE+, PROGRAM CHANGE- , BANK+, BANK-, TAP, BPM+, BPM-) They should all have instantaneous effects, and each time they are triggered, the LED will flash once, not a constant light effect.