alf45tar / PedalinoMini

Wireless and Bluetooth MIDI Foot Controller
GNU General Public License v3.0
505 stars 89 forks source link

Sequence action label setting problem #395

Closed bobvc133 closed 1 year ago

bobvc133 commented 2 years ago

“If action tag end with dot (.) the corresponding led and color is set on boot.” When using the sequence, the action tags can be displayed normally, but the LED and color settings do not take effect Snipaste_2022-11-14_15-30-20

Snipaste_2022-11-14_15-40-22 Snipaste_2022-11-14_15-40-33

alf45tar commented 2 years ago

Give a try to version 3.0.2

bobvc133 commented 2 years ago

Give a try to version 3.0.2

The 3.0.2 firmware has other issues with the LEDs. When switching user profiles, the LEDs that were turned on in the previous user profile will remain on.

alf45tar commented 2 years ago

Fixed. Version remain 3.0.2.

bobvc133 commented 2 years ago

Fixed. Version remain 3.0.2.

Another new problem was found, the LED will flash the set color first during the process of booting up and connecting to the network.

alf45tar commented 2 years ago

This is not a bug. PedalinoMini works via Bluetooth during WiFi access point connection (or if WiFi is disabled). The initial led status is set before starting the WiFi connection.

bobvc133 commented 2 years ago

Give a try to version 3.0.2

Can you fix the LED issue again with the 2.5.4 firmware? Because I use the resistance ladder mode and have many buttons, the control function of version 3.0.2 is not very practical for me, and it is very inconvenient to configure.

alf45tar commented 1 year ago

Sorry but I have no time to back port fixes to old versions. I am supporting only the last one. However the issue can be fixed removing the -1 from the following lines

https://github.com/alf45tar/PedalinoMini/blob/009cb836cf7acb08430078b100e7f4c5ac19dbd0/src/Controller.h#L1717-L1718

bobvc133 commented 1 year ago

3.0.7 firmware, sending Step by Step has reproduced this problem, and the action tag setting does not take effect.