alf45tar / PedalinoMini

Wireless and Bluetooth MIDI Foot Controller
GNU General Public License v3.0
474 stars 83 forks source link

3.2.0 Firmware issues #464

Closed bobvc133 closed 5 months ago

bobvc133 commented 10 months ago

1.Because creating a new configuration will cause a restart, I used JSON Editor to create a complete configuration, which can be imported, applied and saved. However, it will still restart when I create a new configuration again, and the new configuration is still incomplete.(Fixed, spiffs occupancy rate is too high resulting in)

FM3(complete).txt FM3(incomplete).txt

2.When configuring an analog pedal in a bank other than the global bank, the corresponding LED will light up by default.

Snipaste_2023-09-18_15-42-45

3.Incomplete message types in configuration editor ,Some event sending content is empty after creating a new configuration, and the JSON Editor has no option to edit and save.@alf45tar

Snipaste_2023-10-15_12-31-14 20231015124325

4.When the sequence is configured with 10 steps, the Step by Step- event will not go backwards when it reaches the 10th step, and step 1 of the Step by Step+ and Step by Step- events on the action page will be automatically modified to 255.(It has been fixed) Snipaste_2023-10-25_01-33-14 Snipaste_2023-10-25_01-32-23

alf45tar commented 8 months ago

Can you explain point 2?

bobvc133 commented 8 months ago

Can you explain point 2?

Configure the analog pedal in BANK1-20, and the corresponding LED will light up by default, just like adding a (.) ending to the action tag, and set the corresponding LED and color at startup. There is no such problem when configuring analog pedals in Global BANK.

bobvc133 commented 8 months ago

What is missing in the third question is not only the items in the red box, but also actions such as Repeat and Repeat Overwrite.

bobvc133 commented 8 months ago

5、In addition, how to use the OSC Message item in the event? Snipaste_2023-10-29_21-53-51

bobvc133 commented 8 months ago
  1. Another problem was discovered. Starting from firmware 3.1.11, There is a conflict between single-button controls and double-button controls, and the action configuration is invalid.

Snipaste_2023-12-24_21-28-06 Snipaste_2023-12-24_21-28-13

bobvc133 commented 7 months ago
  1. Regarding the third question, there are still inconsistencies in the codes related to actions and sequence events. Some of the names of schema.json, Config.h, and WebConfigAsync.h are different, and some are missing items. The picture below is a list of my statistics.
alf45tar commented 7 months ago
  1. Fixed inconsistence in version 3.1.14 (not yet released)
bobvc133 commented 7 months ago
  1. Fixed inconsistence in version 3.1.14 (not yet released)

8.When editing the pedal pressing mode in jsoneditor, an error message will appear when changing the mode 12L to 1, 2, or 12. There is no problem when selecting the L, 1L, or 2L options. Snipaste_2023-12-09_21-59-05 Snipaste_2023-12-09_21-59-35 Snipaste_2023-12-09_21-59-51

alf45tar commented 7 months ago

It is not a PedalinoMini issue but a Json Editor feature explained here how to use it https://github.com/josdejong/jsoneditor/issues/1541#issuecomment-1653919721

bobvc133 commented 6 months ago
  1. Fixed inconsistence in version 3.1.14 (not yet released)

The action code of the 3.2.0 firmware is still confusing in many places, such as "MIDI Off" and "MIDI Clock Off", "Start", "Stop", "Continue" and "MTC Start", "MTC Stop"," MTC Continue".

Snipaste_2023-12-24_13-22-42 Snipaste_2023-12-24_13-24-12 Snipaste_2023-12-24_13-25-46 Snipaste_2023-12-24_13-26-01 Snipaste_2023-12-24_13-26-28 Snipaste_2023-12-24_13-26-54

bobvc133 commented 6 months ago

Snipaste_2023-12-24_20-56-36 Snipaste_2023-12-24_20-56-52

bobvc133 commented 6 months ago

Snipaste_2023-12-24_21-00-21 Snipaste_2023-12-24_21-01-08

bobvc133 commented 6 months ago

Except for the fourth and eighth problems above, the rest still exist in the 3.2.0 firmware.

alf45tar commented 6 months ago

Renamed "MIDI off" to "MIDI Clock Off" into schema.json. The rest looks good enough to me.

Did you discovered any bug?

bobvc133 commented 6 months ago

Renamed "MIDI off" to "MIDI Clock Off" into schema.json. The rest looks good enough to me.

Did you discovered any bug?

  1. You can select "MTC Start", "MTC Stop", "MTC Continue" and other events on the action page. After creating a new configuration, JSON Editor will prompt an invalid project because there is no corresponding "MTC Start" in the "schema.json" file. , "MTC Stop", "MTC Continue" and other projects. This is the same problem as the lack of "Repeat" and "Repeat Overwrite" projects mentioned before. Although the action page can select events and apply them and save them to the current configuration, after creating a new configuration, JSON Editor An error will be prompted, and when the application is saved to other BANK, an error will appear that the corresponding event is empty.
  2. In the code about the sequence part of the WebConfigAsync.h file, you can see that the event options are "MIDI Start", "MIDI Stop", and "MIDI Continue", but in the relevant condition code, you can see "MTC Start". "MTC Stop", "MTC Continue" and other events, I'm not sure if this is a bug.

Snipaste_2023-12-25_01-39-09

alf45tar commented 6 months ago

Got it. It will fixed in 3.2.1

alf45tar commented 6 months ago

Problem 1. I cannot duplicate. I can upload FM3 config file and then save a new configuration without reboot on my T-Display board.

bobvc133 commented 6 months ago

Problem 1. I cannot duplicate. I can upload FM3 config file and then save a new configuration without reboot on my T-Display board.

After many tests, in the following two situations, restarting when creating a new configuration or incomplete new configuration often occurs. 1. When the new configuration contains a lot of content. 2. There are already multiple configurations in the configuration list. Create a new configuration when the SPIFFS utilization reaches 60%~80%. This problem seems to be caused by the high utilization of SPIFFS. Although you can delete other configurations or create new configurations by category, PedalinoMini's 3 user profiles and 21 BANKs will be meaningless because you cannot create so many configurations. In addition, when the BANK takes up a lot, it will have a significant impact on the response speed of the controls. I don't know if this problem can be improved. In addition, the sixth question is whether the 3.2.1 firmware can be repaired. This has a great impact on me. Both the two-button controls and the single-button controls currently cannot be used normally.

alf45tar commented 6 months ago

Did you considered to increase the SPIFFS size?

alf45tar commented 6 months ago

Can you clarify "Both the two-button controls and the single-button controls currently cannot be used normally."?

bobvc133 commented 6 months ago

Can you clarify "Both the two-button controls and the single-button controls currently cannot be used normally."?

This problem has appeared since firmware 3.1.11. Take the following figure as an example. When controls 4, 16, and 6 are all configured with actions, the actions of controls 4, 16, and 6 will not take effect. Delete the action of control 6, and the actions of controls 4 and 16 can take effect normally. Delete the actions of controls 4 and 16, and control 6 can be used normally. The same problem exists with controls 5, 17, and 18.

292672798-1440c09c-1c71-4b9d-9728-150508114a3a 292672806-a7ad9175-09ce-43e8-85ca-ab9287190736 (1)

bobvc133 commented 6 months ago

Did you considered to increase the SPIFFS size?

I am going to replace the 16MB development board. How can I allocate the flash partition size more reasonably? Can you create a partition table for me?

bobvc133 commented 6 months ago

Snipaste_2023-12-28_20-32-43 Snipaste_2023-12-28_20-34-17

alf45tar commented 6 months ago

Did you considered to increase the SPIFFS size?

I am going to replace the 16MB development board. How can I allocate the flash partition size more reasonably? Can you create a partition table for me?

Sure. Which is your board? How many space do you want for SPIFFS?

alf45tar commented 6 months ago

Assuming BPI-Leaf-S3 here the partition table file partitions_bpi_leaf_s3.csv for a SPIFFS of 2112 Kb.

# Name,   Type, SubType,  Offset,   Size,     Flags
nvs0,     data, nvs,      0x9000,   0x5000,
otadata,  data, ota,      0xE000,   0x2000,
app0,     app,  ota_0,    0x10000,  0x2E0000,
app1,     app,  ota_1,    0x2F0000, 0x2E0000,
nvs,      data, nvs,      0x5D0000, 0x10000,
spiffs,   data, spiffs,   0x5E0000, 0x210000,
coredump, data, coredump, 0x7F0000, 0x10000,
bobvc133 commented 6 months ago

Did you considered to increase the SPIFFS size?

I am going to replace the 16MB development board. How can I allocate the flash partition size more reasonably? Can you create a partition table for me?

Sure. Which is your board? How many space do you want for SPIFFS?

I am currently using TTGO_T_DISPLAY, BPI_LEAF_S3, and LILYGO_T_DISPLAY_S3, three development boards, with 4MB and 8MB specifications. I plan to replace them all with 16mb SPI flash. The largest single configuration file I need to use is 20 BANKs. If I save 3 user profiles , how much space SPIFFS should be allocated when there are 60 banks in total? Another question is, if I use 16MB for development, will there be enough memory to add the page turning keystrokes function? Many times the music scores I use are in image format, and I use the photo album of the iPad to view them, and there are other applications that do not support MIDI control.

alf45tar commented 6 months ago

It found this sheet that can build the partition table for you (it is not mine) https://docs.google.com/spreadsheets/d/1M6_qx00ZR82jyWa2slCMcvLtnXR9Q9dnis5mR5YChW8/edit#gid=0

Also this app can be useful https://esp32.jgarrettcorbin.com

bobvc133 commented 6 months ago

It found this sheet that can build the partition table for you (it is not mine) https://docs.google.com/spreadsheets/d/1M6_qx00ZR82jyWa2slCMcvLtnXR9Q9dnis5mR5YChW8/edit#gid=0

Also this app can be useful https://esp32.jgarrettcorbin.com

I re-partitioned the TTGO_T_DISPLAY 4MB development board and the BPI_LEAF_S3 16MB development board. The following is the partition table. Snipaste_2024-01-04_00-45-49 Snipaste_2024-01-04_00-46-56

bobvc133 commented 5 months ago

Can you clarify "Both the two-button controls and the single-button controls currently cannot be used normally."?

In 3.2.2 firmware, the problem of control conflict still exists. A button cannot appear in two controls, otherwise both controls will become invalid.

292672798-1440c09c-1c71-4b9d-9728-150508114a3a 292672806-a7ad9175-09ce-43e8-85ca-ab9287190736 (1)