search

alf45tar / PedalinoMini

Wireless and Bluetooth MIDI Foot Controller
GNU General Public License v3.0
507 stars 90 forks source link

Feature request - Filter SystemReset Messages #527

Open wcraffonara opened 3 months ago

wcraffonara commented 3 months ago

Hi, Would it be possible to implement a simple filter for MIDI active sensing messages (0xFE)?

Implementation: if input message from MIDI IN is 0xFE (active sensing) then do not send it to MIDI OUT.

Use case: some MIDI controllers like Boss ES8/5 do send continous active sensing MIDI messages which causes unwanted noise/popping in audio signal when audio devices do not implement a good shielding between audio and MIDI interface. This noise can be eliminated by filtering this continous active sensing messages.

Thank you for your support

Best regards Walter

alf45tar commented 3 months ago

Yes, it possible with minimal effort.

wcraffonara commented 2 months ago

Will you implement it? or can you tell me where in the code I can add it? Thank you for your support.

alf45tar commented 2 months ago

Search for On*ActiveSensing functions in all files and comment the code.

wcraffonara commented 1 month ago

Hi, sorry, my fault. It's not the Active Sensing message I want to filter but I need to filter the SystemReset Messages (this is shown in the Terminal when I start monitoring). Can you give me a hint what I should modify in the code or were I can find the place were the SystemReset Message are sended?

I tried already to comment out every line where this SystemReset is sent to DIN MIDI but it doesn't work.

Thank you very much!

Regards Walter

wcraffonara commented 1 month ago

Solved: in MIDI.hpp line 1457 comment out "case SystemReset" in funciton void MidiInterface<Transport, Settings, Platform>::thruFilter(Channel inChannel)