Open theodorejb opened 10 years ago
Thanks for this. A couple small things:
skipPageReset
, which will make it consistent with other similar arguments in other functions throughout dynatable.!==
instead of !=
, since we don't want to make assumptions about what the actual query function will be (so the only assumption being that two identical values are going to be considered identical). In other words, it's possible that a query function considers two values inequivalent that would still have !=
be false.
Currently, adding a custom query method always resets the page. However, this is not always the desired behavior. For example, it may be necessary to add custom query methods as part of the init process without resetting the page (so that page links and bookmarks will work).
Additionally, the page should only be reset if the filter is not already applied. This allows navigation between pages when a filter is applied to work correctly with back/forward buttons.