search

alfasoftware / astra

Astra: a Java tool for analysing and refactoring Java source code
Apache License 2.0
68 stars 35 forks source link

Logging in astra-cli should use org.apache.log4j.Logger #1

Closed RadikalJin closed 3 years ago

RadikalJin commented 3 years ago

Currently, the logging in astra-cli uses System.out.println. This should be updated to match the approach in astra-core, where we use org.apache.log4j.Logger.

An example of our logging in astra-core can be seen in the TypeReferenceRefactor

The logging that needs to be updated to match is in:

RadikalJin commented 3 years ago

Hi, thanks for your interest in Astra!

That would be great! Please take a look at our contribution policy, and raise a pull request: https://github.com/alfasoftware/astra/blob/main/CONTRIBUTING.md

On Mon, 15 Mar 2021 at 15:44, Alex @.***> wrote:

i would like to work on this

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alfasoftware/astra/issues/1#issuecomment-799524223, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACP64E62MPWGHRVCGDADLO3TDYTPVANCNFSM4Y3LIQPQ .

RadikalJin commented 3 years ago

This has now been fixed by pull request #6. Thank you @AlexS968!

Closing the issue now.