search

alfasoftware / astra

Astra: a Java tool for analysing and refactoring Java source code
Apache License 2.0
68 stars 35 forks source link

Add tests for MethodMatcher matching on return type #4

Closed RadikalJin closed 3 years ago

RadikalJin commented 3 years ago

The MethodMatcher provides the option to match by return type. This isn't currently unit tested - coverage for this feature should be added to TestMethodMatcher.

SivaTharun commented 3 years ago

@RadikalJin i am newbie to open source contribution, can i start working on this issue.

RadikalJin commented 3 years ago

Hello @SivaTharun - and thank you for your interest in Astra!

That would be great. Our contribution policy has a couple of tips for getting started.

SivaTharun commented 3 years ago

Thanks @RadikalJin for the info on contribution guidelines

vihaannnn commented 3 years ago

@RadikalJin May I contribute to this project by working on this issue? This is my first contribution to the open source community.

RadikalJin commented 3 years ago

Hello @vihaannnn - that would be great! Our contribution policy has a couple of tips for getting started - thank you for your interest in Astra.

vihaannnn commented 3 years ago

@RadikalJin Thank You! As it is my first time contributing I am not sure how to run this codebase too see if what I will do works... could you help me out there?

RadikalJin commented 3 years ago

@vihaannnn For this issue, there shouldn't be much in the way of setup - we're just adding to existing JUnit tests in TestMethodMatcher.

For information on how Astra works generally, take a look at the Wiki - I think the most useful information for working on this issue will be found in Start with tests!, which describes how we write unit tests for Astra. Luckily, we'll be able to skip most of the setup (like adding the maven dependency) - since we're just adding to a test class which is already setup in Astra - TestMethodMatcher.

Hopefully the other tests in that class provide a useful template - let me know if you have any questions!

RadikalJin commented 3 years ago

Fixed by #55