search

alfem / telegram-downloader-bot

A Telegram bot for file downloading automation
Other
126 stars 49 forks source link

Create Github action to publish the docker #17

Open baruchiro opened 4 years ago

baruchiro commented 4 years ago

You can use GitHub Actions to auto publish the docker image to docker registry.

I can help you with that, but I have no "media server" (respbery PI or something), so it is currently a low priority for me.

alfem commented 4 years ago

Thanks for the suggestion, but I am not the author of docker files (I just coded this bot as a proof of concept). Perhaps @mitto98 could help with this.

mitto98 commented 4 years ago

If you want, since the repo is yours, you can publish it freely on docker hub, otherwise, I can do it.

alfem commented 4 years ago

My laptop conked out a few days ago. If you think an image of this bot will be helpful, feel free to upload it.

I am no a docker expert but images are architecture dependent, aren't they?

baruchiro commented 4 years ago

All we need is Docker Login credentials. I think @alfem should be the owner of these credentials since he is the owner of this repo. Anyone can create the docker in the registry and give the passwords to @alfem.

And I think Github Action for publishing will be good.

mitto98 commented 4 years ago

Yes, they are platform dependent but is possible to build arm in an x86 machine. Tomorrow after work I'll create the image with, at least, support for x86. I don't think is a good idea to give his docker hub credentials to strangers, but whenever you want I can give you the ownership of the docker hub repository.

mitto98 commented 4 years ago

Since I'm not the owner of the repo I'm not allowed to add an action, but I've created a pr with some edits and a script to build and pull the image. @alfem what do you think about adding a license?

alfem commented 4 years ago

Not a bad idea, @mitto98. I am not interested in earning millions of $$ with this bot :-D so a GPL3 could work.

baruchiro commented 4 years ago

@mitto98 I'm working on the brother repo- https://github.com/alfem/telegram-download-daemon. I want to publish a docker, do you think it will be best if these two docker-brothers will be under the same user?

Because that is what I thinking, and I want you to create another item in your Dockerhub account to hold the second docker.

Please come to talk with me in https://github.com/alfem/telegram-download-daemon/issues/3

mitto98 commented 4 years ago

Currently, I'm working on a university assignment, so, you know, lack of time. I've created the repository (https://hub.docker.com/repository/docker/mitto98/telegram-download-daemon), let me know when you have finished, so I can build and push it. I'm excited to try this script 🤩

baruchiro commented 4 years ago

Please create a comment here so we will discuss in the right place