search

alfert / propcheck

Property based Testing for Elixir (based upon PropEr)
GNU General Public License v3.0
376 stars 42 forks source link

Set proper to the official 1.4 release #226

Open alfert opened 8 months ago

alfert commented 8 months ago

@evnu Any ideas why this fails? It does so also locally on my machine. But I was too long away from Elixir to have a good intuition here.

evnu commented 8 months ago

@alfert I think I saw that error with proper some time ago. Currently on mobile, but this might give a hint: https://github.com/proper-testing/proper/blob/a5ae5669f01143b0828fc21667d4f5e344aa760b/src/proper_gen.erl#L361 was there a version bump in proper that we need?

evnu commented 8 months ago

@alfert I thought we fixed the eunit error with this: https://github.com/alfert/propcheck/pull/224

evnu commented 8 months ago

@alfert ok, so the current proper release on hex.pm is just too old. That's why we used a git revision.

alfert commented 8 months ago

This is bad, since we cannot create a proper hex release with dependency on a git hash :-(

evnu commented 8 months ago

@alfert so time to ask for a PropEr release then I guess 🙈

evnu commented 5 months ago

Seems that there is no new release coming for PropEr any time soon. :-/

alfert commented 5 months ago

Yes, feels like Kostis has abandoned PropEr for some time. One way forward could be introducing a fork of PropEr with minor updates (i.e. no new features except for maintenance / upgradability of the Erlang platform). Not sure about it.

evnu commented 5 months ago

Forking would mean to release PropEr to hex.pm, I think that's probably more work than we want to have for PropCheck :) Can we vendor-in PropEr and have that as part of this source tree?

alfert commented 5 months ago

As a git submodule?

evnu commented 5 months ago

If that's possible. This needs to work with mix release as well, I don't know if the Elixir tooling handles vendoring.