search

alfg / mp4-rust

MP4 reader + writer library in Rust! 🎥🦀
https://crates.io/crates/mp4
MIT License
292 stars 80 forks source link

Try to skip extended header in MetaBox. #111

Closed w-flo closed 1 year ago

w-flo commented 1 year ago

Fixes #102

I've made sure cargo test still works, but I haven't looked into the tests to see if they actually cover this piece of code. So if they don't, more testing is needed.

Other than that, I've tested this with my mp4 files that were affected by #102 and it fixes the issue for me.

w-flo commented 1 year ago

This conflicts with #95. I can probably change the logic in my PR a bit so they are compatible.

w-flo commented 1 year ago

Pushed a new commit that should have better compatibility with the other PR

Edit: I suspect the "UdtaBox" in the return Err() path in the current release is a typo and me changing it to "MetaBox" is correct?