search

alfg / murmur-rest

:headphones: A RESTful API for administering virtual Mumble servers. Built with Flask and Ice.
https://github.com/alfg/murmur-rest
79 stars 34 forks source link

Fix encoding and add Ice secret support #5

Closed fwaggle closed 8 years ago

fwaggle commented 8 years ago

Ice properties needed to be added so I could force encoding, otherwise my Ice 3.5 client couldn't connect to a static Linux server. While I was there, I added rudimentary support for using an Ice secret, just because it's about three lines, mostly just copied from mice.py in the Murmur source tree.

I'm not entirely sure that encoding the secret to ASCII is correct, as I believe Mumble supports UTF-8 in secrets. I'll investigate that and change it later.

We could probably add support for a read secret as well for better privsep, but I don't think it's necessary at the moment - if someone owns the REST endpoint the administrator probably has bigger problems - and it'd make things much more complicated.

alfg commented 8 years ago

Thanks! Looks great and thanks for adding in support for Ice secrets too!