Data to collect still appears even after the fields are disabled / multiple choice (checkbox)

icougil commented 7 months ago

Describe the bug After disabling one of the fields you can include in the "Attendees' data to collect" section, it still appears in the reservation / public view (where the users could buy a ticket).

To Reproduce Steps to reproduce the behaviour:

Go to the admin web
Inside the "Attendees' data to collect" section, choose a "Multiple choice (checkbox)" and deselect one of the elements you have added there previously
Save the changes
Go to the reservation/public view and try to buy a ticket. You will still see the previous values in the checkbox

Expected behaviour We expect not to see the disabled element/s

Screenshots

Admin
Public

Desktop (please complete the following information):

OS: OSx
Browser: Chrome
Version: 121

Additional context Side note/another bug?: we found that using the "&" as a Text value in the "Multiple choice (checkbox)" made it impossible to continue with the reservation and, therefore, not move to the buying page.

syjer commented 7 months ago

hi @icougil , thank you reporting this bug: I'm able to reproduce the issue in the main branch.

However I'm not able to reproduce the '&' issue.

syjer commented 7 months ago

As a fix, we will do something similar, as it goes further than simply hide a field on the client side:

we should let the user that had already set this disabled value to view it and resend it, as the user may simply want to update the email or name, we could also gray out the disabled field, this imply that we also need to change the validation rule, as it must consider if the user has already set a disabled value before.
else we should hide it

On the client side: we should hide if there was no value already pre-set, else we display it gray. On the backend: we should allow to re-send disabled value only if the user had already set that value.

This bug affect: checkbox and radiobutton. Select seems to be handled more correctly, but the proposed improvement should allow a more user intuitive flow.

alfio-event / alf.io

Data to collect still appears even after the fields are disabled / multiple choice (checkbox) #1332