supporting "percentage fee" additional items

[cbellone]

fix #1283

Sponsored by Offbeat Tickets

[sonarcloud[bot]]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
69.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[crutchcorn]

Hey all!

I'm the maintainer of TanStack Form (which seems to've been introduced in this PR).

As far as I can tell, y'all are the open-source project with the most stars currently using Form.

Just wanted to drop a line, say "thanks" for picking our tool, and see how the experience was, and if there's anything in particular you'd want us to sure up prior to our 1.x release. 😊

In particular, I know our Lit docs are lacking - we have a ticket to update that.

Also, I noticed that y'all are using Angular in your repo as well. Is there any chance y'all might be similarly interested in using TanStack Form's Angular adapter? We even had the official Angular core team help me code review that adapter recently:

https://tanstack.com/form/latest/docs/framework/angular/quick-start

Best,

- Corbin

[syjer]

hi @crutchcorn , first of all, thank you for creating this nice library! We are currently doing a modernization of our very old angularjs "admin" frontend, this PR is the first of this big work. As a first impression it seems to work as expected, as we are more familiar with the ReactiveForm which is provided out of the box in angular, the experience is quite similar, so it's a big plus.

The only issue that we have noticed, but we are not really sure if it's problematic is a warning which is printed in the console "Element XXXXXXX scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.".

You can see the exact same warning when trying https://github.com/TanStack/form/tree/main/examples/lit/simple on the first load. Maybe it's a known issue?

[crutchcorn]

@syjer FWIW we get similar updates in React as well, which is a bit of a headache. The challenge is that the frameworks aren't in control of reactivity with our library; our own internal signals implementation is. As a result, there are occasional warnings about things like this from the framework as it seems to get confused about our control of reactivity. AFAIK, that warning should be easily ignored.