Closed scheiby closed 3 years ago
Hi,
thanks for your pull requests, I'm always very excited to see my code/project being used by fellow makers :)
Since I'm not familiar with MQTT yet, I carefully looked through your code and it all seems to make sense. Before accepting your pull request, I wanted to make sure to understand the following:
Cheers from Stuttgart, Alf
Hi Alf,
Code indentation I tried to follow your style. But maybe not completely consistent ... and yes there can be long discussions about this ;-)
Greetings,
Daniel
Just had another look at the code and my only concern at the moment is if AsyncWebServer
somehow interferes with WiFiClient
if both are used, do you have any experience with that?
After my first coffee, I am wondering if #include <ESP8266HTTPClient.h>
is really needed (in my understanding, this is not the case, but maybe I just need a second coffee) ?
good question.
I will build da SCD30-free setup (using some tempsensor for values) and check AsyncWebserver + MQTT compatibity. Planned for weekend, hopefully I will find time ;-)
Daniel
Perfect, thanks :)
I'll provide some more detailed feedback with some comments/suggestions from my side on your pull requests tonight or tomorrow.
Cheers, Alf
Hi,
I plan to build an own CO2 ampel, but would like to add MQTT push to own MQTT server capability.
Code is Arduino: Check passed in vscode IDE, but not runned on ESP itself (SCD30 sensor is missing at the moment).
Code changes in detail:
greetings from Cottbus,
Daniel