search

alfonsodg / demo-web2py

Apache License 2.0
0 stars 0 forks source link

Register should have a password confirmation box #29

Closed alfonsodg closed 10 years ago

alfonsodg commented 10 years ago

From francisb...@gmail.com on February 08, 2009 17:32:58

Most User Registration forms have 2 inputs for password entry. This is needed since it is easy to typo the password without realising (since obscured) thus needing the password retrieval system right away.

tools.py uses SQLFORM to build it's form. Could we patch this to allow an extra field to be added to the Form's Table? A simple bit of javascript could be used to compare the 2 boxes before allowing the form to be submitted (The controller's Form doesn't need to process the extra field in any way)

F

Original issue: http://code.google.com/p/web2py/issues/detail?id=30

alfonsodg commented 10 years ago

From massimod...@gmail.com on February 11, 2009 11:35:02

There is a possible solution in trunk but I am not sure this should be done severside as opposed to client-side via js plugin.

alfonsodg commented 10 years ago

From francisb...@gmail.com on February 11, 2009 15:28:40

Lovely :) Just needs a nicer error than 'invalid expression'

I am convinced it does need to be server-side...we want to support JS-less clients as far as possible for accessibility.

alfonsodg commented 10 years ago

From massimod...@gmail.com on February 11, 2009 17:37:37

OK. can you send me a patch that makes error configurable via auth.messages

alfonsodg commented 10 years ago

From francisb...@gmail.com on February 15, 2009 09:56:31

Patch sent & applied - this ticket can be closed :)

alfonsodg commented 10 years ago

From massimod...@gmail.com on February 22, 2009 09:07:54

Status: Fixed