alfonsogonzalez / AWP

Astrodynamics with Python book, software, and videos. Spacecraft trajectory and attitude modeling and simulation
297 stars 72 forks source link

Unit test failing - test_ITVIM_EME_1963_2_year #45

Open dralov opened 1 year ago

dralov commented 1 year ago

FAILED src/python_tools/unit_tests/test_ITVIM.py::test_ITVIM_EME_1963_2_year - assert 16281.484412598316 == 16097.91128 ± 1.0e+00

I followed the exact install instructions and testing instructions. It may be as a result of recent updates to certain modules being used.

dwagmuse commented 9 months ago

I can confirm I get the same error.

Platform is Mac M2 running MacOS 13.6.x Python packages are: matplotlib: 3.8.2 (required > 3.4.0) scipy: 1.11.4 (required > 1.5.2) spicypy: 6.0.0 (big diff from required >3.1.1) pytest: 7.4.3 (also big diff from required >6.2.3)

all other regression tests pass.

dwagmuse commented 9 months ago

Note that this config also causes interface problems in the plotting library in all of the other example programs. So I changed the requirements.txt as follows: matplotlib == 3.4.0 scipy >= 1.5.2 spiceypy >= 3.1.1 pytest >= 6.2.3

And now the examples run ok but I still get the above error in unit tests

rslippert commented 6 months ago

I just commented those 2 asserts out. Did not try to fix those I also added the following to any unit_tests codes to get them working:

import sys sys.path.append('../')

this will allow the tests to work in that unit_tests directory otherwise AWP needs to be turned into a package which means including a init.py within it which I see nowhere. With a little work, AWP should be packaged and put on pypi.org

That said, my Gateway24 software includes Spacecraft mass,fuel and attitude. I believe what is needed is a 13 state, 6DOF spacecraft simulation with Orion like controls. I will be using my own version similar to Propulsive Lander Simulation TVC for Kepler landings and docking, and my own version of AWP for CR3BP 3 body, with added states for mass and fuel.

(Not that Alfonso's AWP software does not include a lot of useful capabilities)