alfredapp / gallery-edits

Suggest edits to the Alfred Gallery
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Submit Workflow: Emoji Wine #2

Closed BenjaminOddou closed 11 months ago

BenjaminOddou commented 11 months ago

Preflight

The submitted workflow:

Homepage

https://github.com/BenjaminOddou/alfred-emoji-wine

Alfred Forum page

https://www.alfredforum.com/topic/20333-emoji-wine/

Gallery page content

Usage

Search emojis with the wine keyword.

Capture d’écran 2023-07-16 à 14 43 22

↩︎: Copy the emoji to the clipboard. ↩︎: Paste the emoji to frontmost application. ↩︎: Open the emojipedia page.

The harvest keyword is used to refresh the API and manage tags. Tags are used to search a group of emojis with custom keywords or sentences.

Capture d’écran 2023-07-16 à 14 50 42

Capture d’écran 2023-07-16 à 14 57 27

Capture d’écran 2023-07-16 à 14 57 42

Tags

emoji, api, emoji-picker, emojipedia

Test data

/

Homebrew dependencies

Pillow

Bundled libraries

No bundled library.

BenjaminOddou commented 11 months ago

Example of tags (must be named tags-<en/fr...>.json) to be placed in ~/Library/Application Support/Alfred/Workflow Data/com.benjamino.emoji_wine.

[
    {
        "id": "7df02fe8d440",
        "title": "French Touch",
        "emojis": [
            "🥐",
            "🧀",
            "🍾",
            "🇫🇷",
            "🥖",
            "🍷"
        ]
    },
    {
        "id": "078f7f569d84",
        "title": "Unicode 15.0",
        "emojis": [
            "🫸🏽",
            "🪈",
            "🪭",
            "🫷🏽",
            "🫨",
            "🫸🏼",
            "🫏",
            "🪼",
            "🫸🏻",
            "🐦‍⬛",
            "🫷🏼",
            "🩵",
            "🫚",
            "🫸",
            "🩶",
            "🫷🏾",
            "🪇",
            "🫛",
            "🫎",
            "🪮",
            "🪻",
            "🫷🏻",
            "🫸🏾",
            "🩷",
            "🫷🏿",
            "🫸🏿",
            "🫷",
            "🛜",
            "🪽",
            "🪿",
            "🪯"
        ]
    }
]
vitorgalvao commented 11 months ago

Unfortunately, the Pillow library is making this impossible to run. Those binaries, the .so files, are not signed and thus are stopped by macOS. Sometimes those aren’t actually crucial and can be deleted without repercussions, but in this case that doesn’t work.

However, I looked around and pillow is available as a Homebrew formula so it may be possible for you to shift to use that instead? Then pillow would be listed as a dependency of the workflow and installable via the dependencies manager.

This is tangential, but it looks like you have installed the library with a Homebrewed Python. They should always be installed with the Python which ships with macOS (/usr/bin/python3) to ensure they work on most people’s installations. That doesn’t matter for this case though, as it’s not the source of the issue.

BenjaminOddou commented 11 months ago

@vitorgalvao, indeed I didn't realized that I was shipping unsigned binaries. Normally I am putting all my python dependencies along with the workflow, that's why !

I can remove the lib folder inside the workflow and make pillow in the list of homebrew package (I am gonna change the docs also) then it should be good to go ? Is there other improvements I should do ?

Many thanks in advance.

BenjaminOddou commented 11 months ago

@vitorgalvao, I updated the workflow and removed the embedded pillow library. Now it's required as a Homebrew dependency.

vitorgalvao commented 11 months ago

Thank you for the submission and fast turnaround. It will list not only pillow as a dependency, but python3 as well since it needs a Homebrew version. That required an extra bit of consideration, but everything looks fine. Should be live at https://alfred.app/workflows/benjaminoddou/emoji-wine/ during the day tomorrow.