Submit Workflow: [alfred-readwise]

giovannicoppola commented 7 months ago

Preflight

[X] The Alfred team has invited me to submit this workflow.

The submitted workflow:

[X] Was authored by me. ⓘ
[X] Uses Workflow Configuration or has no user-facing settings. ⓘ
[X] Does not have an auto-updater. ⓘ
[X] Does not contain unsigned and non-notarised binaries. ⓘ
[X] Does not download extra software. ⓘ
[X] Uses keywords with more than one character. ⓘ
[X] Has a descriptive About section. ⓘ
[X] Has an icon of at least 256x256 px. ⓘ

Homepage

https://github.com/giovannicoppola/alfred-readwise

Alfred Forum page

https://www.alfredforum.com/topic/20208-introducing-alfred-readwise-%F0%9F%93%9A/

Gallery page content

List, search, and open your Readwise highlights This workflow requires a Readwise account.

Usage

List and search your highlights via the !r keyword alfred-readwise

# will prompt a label search which can be added to the standard search, multiple labels supported alfred-readwise2

↩: Show the highlight in large font and copy to clipboard
⇧↩: Show the highlight in large font and copy to clipboard without closing Alfred
⌘↩: Open the source URL if available (typically for tweets)
^↩: Open the highlight on Readwise
⇧^↩: Open all highlights from that book on Readwise
⌘Y (or tap ⇧): Quick Look your highlight

Create new highlights by selecting text in any app via the Universal Action universalAction

Test data

No response

Homebrew dependencies

Pillow

Bundled libraries

requests

vitorgalvao commented 7 months ago

Doesn’t look like the screenshots were taken with the correct method. The shadows are cut and too close to the edges.

giovannicoppola commented 7 months ago

sorry! I was being lazy

vitorgalvao commented 7 months ago

The new screenshots also have issues, there’s a distracting blur at each of the four corners. I tried fixing those but it takes an inordinate amount of time and isn’t perfect. Please use one of the main themes, such as Alfred Modern, for the screenshots. That way I can also help with missing screenshots, like I could with ZotHero because I had all necessary details.

Other issues:

There’s a screenshot missing for the Universal Action.
The screenshot was activated via a Hotkey. They should always be invoked by typing the keyword, otherwise new users won’t understand how to get to the state in the screenshot.

giovannicoppola commented 6 months ago

I have added new images. The hotkey disappears when searching labels, I have added an example without labels.

vitorgalvao commented 6 months ago

It’s not clear from looking at the workflow which steps takes one from !r to that # section. What’s missing between those? Also, in testing I bumped into this:

Code 1: /Users/vm/Library/Application Support/Alfred/Alfred.alfredpreferences/workflows/user.workflow.8C289541-5026-4923-97BD-CF23B631B5F5/lib/requests/__init__.py:102: RequestsDependencyWarning: urllib3 (1.26.15) or chardet (5.1.0)/charset_normalizer (2.0.12) doesn't match a supported version!
  warnings.warn("urllib3 ({}) or chardet ({})/charset_normalizer ({}) doesn't match a supported "
Traceback (most recent call last):
  File "/Users/vm/Library/Application Support/Alfred/Alfred.alfredpreferences/workflows/user.workflow.8C289541-5026-4923-97BD-CF23B631B5F5/readwise-query.py", line 17, in <module>
    from readwise_fun import refreshReadwiseDatabase, makeLabelList
  File "/Users/vm/Library/Application Support/Alfred/Alfred.alfredpreferences/workflows/user.workflow.8C289541-5026-4923-97BD-CF23B631B5F5/readwise_fun.py", line 19, in <module>
    from PIL import Image, ImageDraw, ImageFont
ModuleNotFoundError: No module named 'PIL'

Does this require a Homebrew Python instead of the one which ships with macOS? That’s important to mention. And is a library missing? pillow can be installed with Homebrew, perhaps that’s what you did?

giovannicoppola commented 6 months ago

sorry I added this feature upon a user request and I forgot to add this library to requirements.txt. However I just tried and it fails, so it will take a little while to figure it out. Also, I am happy to share my readwise token so you can test.

vitorgalvao commented 6 months ago

However I just tried and it fails, so it will take a little while to figure it out.

The conversation at https://github.com/alfredapp/gallery-edits/issues/2 might be relevant.

Also, I am happy to share my readwise token so you can test.

That would help, thank you. No rush, whenever you feel this is ready for me to take another look.

vitorgalvao commented 6 months ago

Thank you. Will be live today at http://alfred.app/workflows/giovanni/readwise/.

alfredapp / gallery-edits