Possible rush condition between FileWatcher and RepositoryWatcher makes FileWatcher ignore file events and makes it never send content to be parsed and built

[alfredbaudisch]

Sometimes FileWatcher gets stuck and does not react for new file events and does not send content to be rebuilt when it gets started (when the application is started).

Conditions

• It only happens with applications using a remote_repository_url.
• It appears to happen only when root_path doesn't exist when the application is started, because then the root_path physical folder is created by RepositoryProviders.Git on the first repository pull (as soon as the application is started).

How to Reproduce

• Integrate PardallMarkdown with a Phoenix application, which fetches from a Git repository (remote_repository_url). Or just clone alfredbaudisch/pardall_markdown_phoenix_demo.
• root_path must be set to a folder that still doesn't exist.
• Start the Phoenix server iex -S mix phx.server
• RepositoryWatcher will create the root_path folder and clone the content from the Git repository into it
• FileWatcher will report: Content reloader is already busy processing 1 event(s) (for a total of 1 pending event(s)). Will re-schedule. If this happens frequently, consider increasing the [...] but the content will never be parsed and built.
• Subsequent content updates won't also trigger content rebuilding.

Report

• OS: Windows 10

$ iex -S mix phx.server
09:27:42.953 [info][mfa=PardallMarkdown.FileWatcher.handle_info/2 ] Started reloading content...
09:27:43.934 [info][mfa=PardallMarkdown.RepositoryProviders.Git.git_repository/0 ] Cloning repository https://github.com/alfredbaudisch/pardall_markdown_sample_content, into ./sample_content
09:27:43.983 [warn][mfa=PardallMarkdown.FileWatcher.handle_info/2 ] Content reloader is already busy processing 1 event(s) (for a total of 1 pending event(s)). Will re-schedule. If this happens frequently, consider increasing the
09:27:44.484 [info][mfa=PardallMarkdown.RepositoryProviders.Git.repository/0 ] Pulling from git repository Already up to date.

[alfredbaudisch]

Updated from critical to medium-priority because it only happens when root_path still doesn't exist in the server, and is left to be created by RepositoryProviders.Git in the first pull (as soon as the application is started).