search

alfredxing / brick

Open-source webfont service
http://brick.im
2.87k stars 96 forks source link

GitHub Pages doesn't support Jekyll collections #62

Open alfredxing opened 10 years ago

alfredxing commented 10 years ago

Emailed Support about this. According to this page, Pages uses Jekyll 1.5.1, which doesn't yet have collections support.

I'm waiting for their reply, but I guess for now the new fonts page won't be working. Sorry!

alfredxing commented 10 years ago

I got an email back from Support (pretty quick!), and they said that they're working on upgrading to Jekyll 2.0, but can't give an exact date on when it's happening.

For now, I'll build locally and push the built files. I guess I have to do this since brick.php, which actually manages the requests, needs to use collections as well after the recent change.

alfredxing commented 10 years ago

Okay, with 91c7f5769a164178472e5adb64e1c8933b79008c I pushed my compiled version of the fonts/index.html page, and it seems to be working. However, you can't currently click through to the fonts' specimen pages, since pushing those individually would be too much of a pain (we'll wait until the Jekyll upgrade).

With the built version, the entire page (bucket and all) is working, so go ahead and start playing around with it!

I'll be pushing the built version on every font added/changed.

Minor edit: actually, I've found a better way; I've created a hard symlink from _site/fonts/index.html to fonts/index.html so I don't have to worry about copy & pasting anymore! :cool:

namanyayg commented 10 years ago

Any thoughts on an alternate layout that shows a sentence instead of 'Aa'? I'll be willing to work on the layout, but I can't find any info on how to contribute to the site's design, just submitting fonts. Imagining something like Google Fonts.

alfredxing commented 10 years ago

@namanyayg I went with "Aa" because it's a bit easier to go through the whole list of fonts, but if you want to work on the layout, go ahead! The catalogue page is _fonts/index.html; it's generated with Jekyll, so you'll probably need to work with that.

Maybe we can have an option to toggle between "Aa" and a sentence, but I'm still not too sure about loading all of the fonts for that use (we used images previously).

Perhaps you can open up a new issue for this as well to keep the project a bit more organized.

Thanks!

namanyayg commented 10 years ago

Awesome, I'll have a go. I admit I don't have much Jekyll experience, though.

alfredxing commented 10 years ago

@namanyayg It's not too hard, you can just follow what I did. I'm guessing most of your changes will be to the CSS anyway.

namanyayg commented 10 years ago

@alfredxing CSS and JS, yup. Thanks for the info!

alfredxing commented 10 years ago

With #69, the site is working, but I'll keep the issue open because I'd still like to go back to only needing one branch (and GitHub did say they were working on updating Jekyll).

alfredxing commented 10 years ago

GitHub Pages supports collections now, but not static files in collections (I believe that's in 2.3.0). We'll wait for that, then we can start a discussion on whether to move back to collections.