search

alganzory / HaramBlur

A Browser extension that enables you to navigate the web with respect for your Islamic values, protect your privacy and reduce browsing distractions by auto detecting and blurring "Haram" content.
https://haramblur.com
GNU Affero General Public License v3.0
404 stars 30 forks source link

Support Internationalization (other languages) #16

Open alganzory opened 10 months ago

anonfaded commented 8 months ago

Working on this feature brother, can you assign this issue to me :)

alganzory commented 8 months ago

Thanks @anonfaded

anonfaded commented 8 months ago

Brother i have added arabic language to the HaramBlur extension but there are some issues which i can't figure out so need guidance.

I did two things:

  1. Added IDs in the tags in popup.html file.
  2. Added translations.js file which contains the translations.

But the issue is with the tooltip, the blur and the strictness % value which isn't showing on both english and arabic version which you can see in the attached screenshot below. Screenshot from 2023-12-16 18-14-03

The buttons of grayscale, image etc all are working fine and it blurs the images but it doesn't show the percentage.

Also when i load the extension it loads like you saw above but when i upload the unzipped extension which we get from npm run release command, then the arabic translation when picked from the dropdown doesn't work and also the tooltip and % is visible as it is now in the online extension.

Sharing a fullscreen screenshot below and waiting for your suggestion on what to do now, should i open the pull request if you can handle the rest? or any guidance on how to fix this issue. Screenshot from 2023-12-16 20-22-33

Check the code here:

https://github.com/anonfaded/HaramBlur

alganzory commented 8 months ago

Thank you for your efforts, May Allah bless you

I think it's best if you open a PR first and then I'll look at the changes and see what could be causing the bugs. For one, I think the build problem you're getting is because you haven't added the new files to the release command in package.json. But again, please open a PR so I can look into it further

Jazak Allahu Khairan

anonfaded commented 8 months ago

yes please review the code, and I'm here for any further steps that i may have missed. If everything goes fine and we find the solution then i will recheck the translations and will correct them after i verify that from arabic speaking friend.