algebraic-solving / AlgebraicSolving.jl

Other
18 stars 10 forks source link

Signature Gröbner basis implementation #19

Closed RafaelDavidMohr closed 11 months ago

RafaelDavidMohr commented 12 months ago

Main function is sig_groebner_basis. I also added a homogenize function and a cyclic function. Let me know which of them should be exported.

codecov-commenter commented 11 months ago

Codecov Report

Attention: 170 lines in your changes are missing coverage. Please review.

Comparison is base (f86e10b) 94.87% compared to head (943c411) 84.65%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #19 +/- ## =========================================== - Coverage 94.87% 84.65% -10.22% =========================================== Files 6 14 +8 Lines 273 1199 +926 =========================================== + Hits 259 1015 +756 - Misses 14 184 +170 ``` | [Files](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/AlgebraicSolving.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL0FsZ2VicmFpY1NvbHZpbmcuamw=) | `50.00% <ø> (ø)` | | | [src/algorithms/solvers.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2FsZ29yaXRobXMvc29sdmVycy5qbA==) | `92.18% <100.00%> (ø)` | | | [src/examples/cyclic.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2V4YW1wbGVzL2N5Y2xpYy5qbA==) | `100.00% <100.00%> (ø)` | | | [src/siggb/typedefs.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NpZ2diL3R5cGVkZWZzLmps) | `100.00% <100.00%> (ø)` | | | [src/siggb/linear\_algebra.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NpZ2diL2xpbmVhcl9hbGdlYnJhLmps) | `88.88% <88.88%> (ø)` | | | [src/siggb/siggb.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NpZ2diL3NpZ2diLmps) | `88.52% <88.52%> (ø)` | | | [src/siggb/monomials.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NpZ2diL21vbm9taWFscy5qbA==) | `74.62% <74.62%> (ø)` | | | [src/siggb/symbolic\_pp.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NpZ2diL3N5bWJvbGljX3BwLmps) | `89.49% <89.49%> (ø)` | | | [src/siggb/update.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NpZ2diL3VwZGF0ZS5qbA==) | `77.40% <77.40%> (ø)` | | | [src/siggb/hashtable.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NpZ2diL2hhc2h0YWJsZS5qbA==) | `71.61% <71.61%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.