search

algebraic-solving / AlgebraicSolving.jl

Other
18 stars 10 forks source link

Avoid obsolete names for functions and types #21

Closed fingolfin closed 9 months ago

fingolfin commented 9 months ago

CC @ederc @thofma

codecov-commenter commented 9 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5d1cc94) 94.87% compared to head (7b6f308) 94.87%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #21 +/- ## ======================================= Coverage 94.87% 94.87% ======================================= Files 6 6 Lines 273 273 ======================================= Hits 259 259 Misses 14 14 ``` | [Files](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/21?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/algorithms/groebner-bases.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/21?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2FsZ29yaXRobXMvZ3JvZWJuZXItYmFzZXMuamw=) | `100.00% <ø> (ø)` | | | [src/examples/katsura.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/21?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2V4YW1wbGVzL2thdHN1cmEuamw=) | `97.43% <100.00%> (ø)` | | | [src/interfaces/nemo.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/21?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2ludGVyZmFjZXMvbmVtby5qbA==) | `98.14% <ø> (ø)` | | | [src/types.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/21?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3R5cGVzLmps) | `94.11% <100.00%> (ø)` | | | [src/algorithms/solvers.jl](https://app.codecov.io/gh/algebraic-solving/AlgebraicSolving.jl/pull/21?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2FsZ29yaXRobXMvc29sdmVycy5qbA==) | `92.18% <76.47%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ederc commented 9 months ago

@fingolfin Thanks!

fingolfin commented 9 months ago

@ederc could you perhaps make a new release with this in? I see that you just merged some bigger changes atop, so if that's a problem, a release made from a commit right after this PR was merged would also be fine.