search

algebraic-solving / AlgebraicSolving.jl

Other
18 stars 10 forks source link

chore: adjust compat entry for Nemo and bump version #38

Closed thofma closed 6 months ago

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (40127ab) 94.56% compared to head (4c2e1ee) 94.56%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #38 +/- ## ======================================= Coverage 94.56% 94.56% ======================================= Files 15 15 Lines 1250 1250 ======================================= Hits 1182 1182 Misses 68 68 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ederc commented 6 months ago

@thofma Any ideas why the julia v1.6 tests fail? Is the (f, NARGS) = (AlgebraicSolving.submul, 4) output coming from the new Nemo version?

thofma commented 6 months ago

Hm, no clue. I will have a look tomorrow.

thofma commented 6 months ago

I just noticed that the documentation build pinned Nemo to 0.36.*, which is rather old. Let's see what happens now.

thofma commented 6 months ago

OK, I will have to adjust a few things tomorrow.

ederc commented 6 months ago

OK, thanks, let me know if I can help you tomorrow.

thofma commented 6 months ago

I think I got everything working now. But I just noticed something about the printing, which we should fix now in Nemo. So let's put this on hold for a moment.

thofma commented 6 months ago

Ignore my previous comment. I just had to add an export statement here. Everything should be good to go now. Sorry for the confusion.