search

algebraic-solving / AlgebraicSolving.jl

Other
18 stars 10 forks source link

Fix bug on variables permutation, when additional variables #46

Closed rprebet closed 4 months ago

rprebet commented 4 months ago

Reordering the variables in the output of msolve moves additional variables from the end to the beginning, while we want to ignore their values when isolating.

This caused an "index out of range" when pairing the isolated values and the corresponding variables, because we do not isolate values of additional variables. This happens for the system [x^2-1,y^2] for example, so I added it to the tests.

This is my first pull request ever, I hope I've done things right.

ederc commented 4 months ago

@rprebet Thank you very much for your PR. I just made the test a bit more robust.