search

algebraic-solving / msolve

Library for Polynomial System Solving through Algebraic Methods
https://msolve.lip6.fr
GNU General Public License v2.0
84 stars 21 forks source link

Sage file interface bug fixes #109

Closed SriramGDev closed 7 months ago

SriramGDev commented 7 months ago

This PR fixes two bugs in the Sage file interface for msolve:

  1. When computing rational parametrizations of zero-dimensional ideals using the Sage file interface, the FormatOutputMSolve method incorrectly parses msolve output files. As of this PR, the output is correctly parsed.
  2. If MSolveRealRoots is provided with a positive-dimensional ideal, an error is thrown when trying to parse the msolve output file. As of this PR, no error is thrown and instead the intended behavior of notifying the user that the system has infinitely many complex solutions is correctly implemented.
ederc commented 7 months ago

@SriramGDev Could you please rebase on current msolve master, then the checks should pass and I can merge.