search

algebraic-solving / msolve

Library for Polynomial System Solving through Algebraic Methods
https://msolve.lip6.fr
GNU General Public License v2.0
90 stars 22 forks source link

Make function declarations & definitions agree #70

Closed jamesjer closed 1 year ago

jamesjer commented 1 year ago

There are several instances where function declarations and definitions do not match. This PR adds #include "libfglm.h" to fglm_core.c to catch future mismatches. The change to msolve_ff is undoubtedly wrong, but I wasn't sure where to get hold of an appropriate stat_t in that function.

This came up because I am evaluating msolve for possible inclusion in the Fedora Linux distribution. We build packages with LTO (specifically -flto=auto -ffat-lto-objects), and with -Wall. With LTO enabled, -Wall includes -Wlto-type-mismatch, which reported these issues.

ederc commented 1 year ago

Thanks.

For msolve_ff: This is deprecated code, thus I used your PR to directly remove these parts, so no problem with stat_t objects.