algebraic-solving / msolve

Library for Polynomial System Solving through Algebraic Methods

https://msolve.lip6.fr

GNU General Public License v2.0

90 stars 22 forks source link

Closed mezzarobba closed 11 months ago

mezzarobba commented 1 year ago

...while remaining compatible with flint2.

There are still some warnings that I think should be fixed on the flint side, see https://github.com/flintlib/flint2/issues/1390.

mohabsafey commented 12 months ago

Thanks for this proposal. Currently, it does not pass the CI tests. You should use the preprocessor with the statement

if __FLINT_VERSION < 3

to include the nmod.h file

mezzarobba commented 11 months ago

Right, nmod.h has been there for some time, but maybe not since the oldest flint version supported by msolve.

vneiger commented 11 months ago

CI checks went well, and modifications look right for me (checked on my install where I had the same issue with recent flint).